Reduce Tenderly request fan-out#1325
Open
rossgalloway wants to merge 2 commits into
Open
Conversation
Keep portfolio balances canonical while refreshing only active vault workflow tokens from Tenderly. - bound VNet transaction history lookups behind explicit modes - scope simulated balance overrides to the active vault route - reject unsuccessful snapshot reverts in the admin CLI This avoids broad VNet multicalls while preserving simulated workflow state.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Document safe Tenderly VNet usage for scripts, including scoped live runs, RPC budgeting, cleanup guarantees, and status-query limits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep global wallet balances canonical through Enso in Tenderly mode while refreshing only the tokens required by the active vault workflow from the VNet. This also bounds VNet status transaction-history requests, rejects unsuccessful snapshot reverts in the admin CLI, and adds the reference branch's Tenderly script safety guidance.
Standalone vault-widget application files, QA runners, and package commands remain intentionally excluded because the widget does not exist on
main. Thescripts/AGENTS.mdguidance is included verbatim from the reference branch as requested.How to review
Start with
useTenderlyVaultBalanceOverrides.tsanduseWallet.tsxto review the route-scoped override lifecycle, including reconnect cleanup. Then reviewuseBalancesCombined.tsanduseBalancesRouting.tsfor the Tenderly-mode Enso routing, followed by the VNet status and CLI changes underscripts/.Review
scripts/AGENTS.mdseparately as operational guidance copied from the reference branch. It includes safety rules for the future vault-widget QA runner, while that runner itself is not part of this PR.For a smoke test, enable Tenderly mode in a non-production environment, open a vault detail route, fund or revert the connected wallet, and confirm the active vault balances refresh while portfolio balances remain canonical. Leaving the route or reconnecting should clear and rebuild the scoped override.
Test plan
bun run lint:fixandbun run lintbun run tslintNEXT_PUBLIC_TENDERLY_MODE=false bun run buildscripts/AGENTS.md/and/vaultswith Tenderly mode disabledRisk / impact
The wallet routing and scoped overrides affect Tenderly mode only; normal production balance behavior is unchanged. The primary risk is stale or incorrectly scoped simulated balances on vault routes, covered by unit tests for refresh, cleanup, reconnect, and pricing behavior. The copied script guidance references vault-widget QA commands that are not yet available on
main; it is non-runtime documentation for that future workflow. There are no migrations or production fund movements. Reverting commits662e2b98and9f2eefbarestores the prior behavior.