authhelper: add GUI to manage auth diags

addOns/authhelper/CHANGELOG.md

@@ -11,6 +11,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
 - Add Authentication Report section for the log file.
 - Support for step delay in Browser Based Authentication, which replaces the auth tester "demo mode".
 - Support for min wait for time in Client Script Authentication.
+- Allow to manage the authentication diagnostics through the GUI.
 
 ## Changed
 - Now depends on minimum Common Library version 1.35.0 and Zest version 48.9.0.

addOns/authhelper/src/main/java/org/zaproxy/addon/authhelper/ExtensionAuthhelper.java

@@ -52,6 +52,7 @@
 import org.parosproxy.paros.network.HttpMessage;
 import org.parosproxy.paros.view.View;
 import org.zaproxy.addon.authhelper.internal.db.TableJdo;
+import org.zaproxy.addon.authhelper.internal.ui.diags.AuthDiagsPanel;
 import org.zaproxy.addon.commonlib.internal.TotpSupport;
 import org.zaproxy.addon.commonlib.internal.TotpSupport.TotpData;
 import org.zaproxy.addon.commonlib.internal.TotpSupport.TotpGenerator;
@@ -218,6 +219,8 @@ public void hook(ExtensionHook extensionHook) {
 
             authDiagCollector = new AuthDiagnosticCollector();
             extensionHook.addHttpSenderListener(authDiagCollector);
+
+            new AuthDiagsPanel(extensionHook);
         }
     }
 

addOns/authhelper/src/main/java/org/zaproxy/addon/authhelper/internal/db/Diagnostic.java

@@ -24,6 +24,7 @@
 import java.util.List;
 import javax.jdo.annotations.Cacheable;
 import javax.jdo.annotations.Column;
+import javax.jdo.annotations.Element;
 import javax.jdo.annotations.IdGeneratorStrategy;
 import javax.jdo.annotations.Order;
 import javax.jdo.annotations.PersistenceCapable;
@@ -53,6 +54,7 @@ public class Diagnostic {
     private String script;
 
     @Order(column = "NUMBER")
+    @Element(dependent = "true")
     @Persistent(mappedBy = "diagnostic")
     private List<DiagnosticStep> steps = new ArrayList<>();
 

addOns/authhelper/src/main/java/org/zaproxy/addon/authhelper/internal/db/DiagnosticBrowserStorageItem.java

@@ -65,7 +65,7 @@ public String getScript() {
     @Persistent(valueStrategy = IdGeneratorStrategy.IDENTITY)
     private int id;
 
-    @Column(name = "STEPID")
+    @Column(name = "STEPID", allowsNull = "false")
     private DiagnosticStep step;
 
     @Column(jdbcType = "INTEGER")

addOns/authhelper/src/main/java/org/zaproxy/addon/authhelper/internal/db/DiagnosticMessage.java

@@ -41,7 +41,7 @@ public class DiagnosticMessage {
     @Persistent(valueStrategy = IdGeneratorStrategy.IDENTITY)
     private int id;
 
-    @Column(name = "STEPID")
+    @Column(name = "STEPID", allowsNull = "false")
     private DiagnosticStep step;
 
     private int messageId;

addOns/authhelper/src/main/java/org/zaproxy/addon/authhelper/internal/db/DiagnosticScreenshot.java

@@ -41,7 +41,7 @@ public class DiagnosticScreenshot {
     @Persistent(valueStrategy = IdGeneratorStrategy.IDENTITY)
     private int id;
 
-    @Column(name = "STEPID")
+    @Column(name = "STEPID", allowsNull = "false")
     private DiagnosticStep step;
 
     @Column(length = 8388608)

addOns/authhelper/src/main/java/org/zaproxy/addon/authhelper/internal/db/DiagnosticStep.java

@@ -47,7 +47,7 @@ public class DiagnosticStep {
     @Persistent(valueStrategy = IdGeneratorStrategy.IDENTITY)
     private int id;
 
-    @Column(name = "DIAGNOSTICID")
+    @Column(name = "DIAGNOSTICID", allowsNull = "false")
     private Diagnostic diagnostic;
 
     @Column(length = 4096)
@@ -59,20 +59,22 @@ public class DiagnosticStep {
     @Column(name = "WEBELEMENTID")
     private DiagnosticWebElement webElement;
 
-    @Persistent(mappedBy = "step")
+    @Persistent(mappedBy = "step", dependent = "true")
     private DiagnosticScreenshot screenshot;
 
     @Order(column = "NUMBER")
+    @Element(dependent = "true")
     @Persistent(mappedBy = "step")
     private List<DiagnosticMessage> messages = new ArrayList<>();
 
     @Persistent(table = "AUTHHELPER_DIAGNOSTIC_STEP_WEB_ELEMENTS")
     @Join(column = "STEPID")
-    @Element(column = "WEBELEMENTID")
+    @Element(column = "WEBELEMENTID", dependent = "true")
     @Order(column = "NUMBER")
     private List<DiagnosticWebElement> webElements = new ArrayList<>();
 
     @Order(column = "NUMBER")
+    @Element(dependent = "true")
     @Persistent(mappedBy = "step")
     private List<DiagnosticBrowserStorageItem> browserStorageItems = new ArrayList<>();