Skip to content

commonlib: Remove markdown formatting from solution elements#7147

Merged
thc202 merged 1 commit intozaproxy:mainfrom
Arunodoy18:fix/8056-clean-markdown-in-solutions
Mar 4, 2026
Merged

commonlib: Remove markdown formatting from solution elements#7147
thc202 merged 1 commit intozaproxy:mainfrom
Arunodoy18:fix/8056-clean-markdown-in-solutions

Conversation

@Arunodoy18
Copy link
Copy Markdown
Contributor

@Arunodoy18 Arunodoy18 commented Feb 19, 2026

Relates to zaproxy/zaproxy#8056

Summary

Remove markdown formatting artifacts from <solution> elements in vulnerabilities.xml.

Changes

Three entries contained markdown syntax (**bold** markers and 1. numbered lists) in their <solution> elements. Solutions are rendered as plain text and should not contain markdown.

Affected entries:

  • wasc_21 (Insufficient Anti automation)
  • wasc_45 (Fingerprinting)
  • wasc_48 (Insecure Indexing)

What was changed

  • Removed **bold** markers (e.g., **CAPTCHA:**CAPTCHA:)
  • Converted numbered lists (1., 2., etc.) to dash-prefixed lines (-)
  • No wording changes — all text preserved exactly

Validation

  • No markdown remains in any <solution> element
  • XML is well-formed
  • No changes to <desc>, <alert>, or <reference> elements
  • No structural or ordering changes

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 19, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@psiinon
Copy link
Copy Markdown
Member

psiinon commented Feb 19, 2026

Logo
Checkmarx One – Scan Summary & Details6e462449-a201-47bf-92ed-94fe72ec6ddc

Great job! No new security vulnerabilities introduced in this pull request


Use @Checkmarx to interact with Checkmarx PR Assistant.
Examples:
@Checkmarx how are you able to help me?
@Checkmarx rescan this PR

@Arunodoy18
Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

kingthorin
kingthorin previously approved these changes Feb 19, 2026
@kingthorin kingthorin dismissed their stale review February 19, 2026 14:09

CHANGELOG should be updated.

@Arunodoy18 Arunodoy18 force-pushed the fix/8056-clean-markdown-in-solutions branch from 06c1518 to a7989fe Compare February 19, 2026 14:59
@Arunodoy18
Copy link
Copy Markdown
Contributor Author

CHANGELOG updated 👍
— added CHANGELOG entry under ## Unreleased > ### Changed.

Copy link
Copy Markdown
Member

@kingthorin kingthorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Remove **bold** markers and numbered list syntax from <solution>
elements in wasc_21, wasc_45, and wasc_48. Solutions are plain text
and should not contain markdown formatting.

Relates to zaproxy/zaproxy#8056
@thc202 thc202 force-pushed the fix/8056-clean-markdown-in-solutions branch from a7989fe to d3288f4 Compare March 4, 2026 17:41
@thc202 thc202 requested review from Copilot and removed request for Copilot March 4, 2026 17:41
@thc202 thc202 enabled auto-merge March 4, 2026 17:44
@thc202
Copy link
Copy Markdown
Member

thc202 commented Mar 4, 2026

Thank you!

@thc202 thc202 merged commit 7521770 into zaproxy:main Mar 4, 2026
15 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants