Various changes to address some performance issues#7287
Draft
time4tea wants to merge 15 commits intozaproxy:mainfrom
Draft
Various changes to address some performance issues#7287time4tea wants to merge 15 commits intozaproxy:mainfrom
time4tea wants to merge 15 commits intozaproxy:mainfrom
Conversation
move mutation to constructor where possible make fields final where possible move initialisers to field declarations where possible IDEA Clean-Up
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Member
|
Fixed Issues (1)Great job! The following issues were fixed in this Pull Request
Use @Checkmarx to interact with Checkmarx PR Assistant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Hi -
Related to zaproxy/zaproxy#9302
Here are a set of changes that addressed, for me, the serious performance issues I found trying to use ZAP to spider a website.
This, and the associated PR in the other project - transformed the system from a very slow thing with an unresponsive GUI to something that was very fast, and GUI was responsive throughout.
I appreciate that this PR is probably not something that can be merged in. However, I'm sorry that I don't have the time to split it, and shepherd it through a review process. However, it is offered as-is if it is useful.
The main changes are: