-
-
Notifications
You must be signed in to change notification settings - Fork 783
quickstart: Add Scan Policy option to Automated Scan panel #7300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Adarshkumar0509
wants to merge
12
commits into
zaproxy:main
Choose a base branch
from
Adarshkumar0509:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
dd04522
Add Scan Policy option to Quick Start Automated Scan panel
Adarshkumar0509 7d31089
Address review feedback: use class reference and update changelog
Adarshkumar0509 0d28a2e
Remove redundant cast when getting ExtensionActiveScan
Adarshkumar0509 bb06386
Address review feedback from kingthorin
Adarshkumar0509 fb17451
Address remaining review feedback from kingthorin
Adarshkumar0509 cf77ea6
Address psiinon feedback: default to Dev Standard, save last policy, …
Adarshkumar0509 6790bb9
Fix: apply Dev Standard default and saved policy selection
Adarshkumar0509 caf689e
Address thc202 review feedback
Adarshkumar0509 bf90ec1
Simplify policy loading using forEach and fix static method call
Adarshkumar0509 6df912b
Add unit tests for QuickStartParam scan policy
Adarshkumar0509 dc27728
Fix headless mode and rework getDefaultScanPolicy to be called once
Adarshkumar0509 9dbc905
Address remaining review feedback: inline variables, fix help, revert…
Adarshkumar0509 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -319,6 +319,7 @@ public void attack(URL url, boolean useStdSpider) { | |
| attackThread.setURL(url); | ||
| attackThread.setTraditionalSpider(traditionalSpider); | ||
| attackThread.setPlugableSpider(plugableSpider); | ||
| attackThread.setScanPolicyName(getQuickStartPanel().getAttackPanel().getSelectedPolicy()); | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This will break in headless mode, see |
||
| attackThread.start(); | ||
| } | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.