Add JavaScript prettier support to spotless tasks#7312
Open
kingthorin wants to merge 1 commit intozaproxy:mainfrom
Open
Add JavaScript prettier support to spotless tasks#7312kingthorin wants to merge 1 commit intozaproxy:mainfrom
kingthorin wants to merge 1 commit intozaproxy:mainfrom
Conversation
Member
|
Great job! No new security vulnerabilities introduced in this pull requestUse @Checkmarx to interact with Checkmarx PR Assistant. |
c77b8ab to
b580f77
Compare
| if ( | ||
| item.match(/^-?[£\x24Û¢´€] ?\d/) || // prefixed currency | ||
| item.match(/^-?\d+\s*[€]/) || // suffixed currency | ||
| item.match(/^-?(\d+[,\.]?)+(E[\-+][\d]+)?%?$/) // number |
Member
Author
There was a problem hiding this comment.
This is a pre-existing issue. We could arguably cap it at some number of digits. 🤷♂️
0d5ef6e to
7db2c0a
Compare
Signed-off-by: kingthorin <kingthorin@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Overview
Format JS scripts with Prettier via the Spotless Gradle plugin.
The dependency on
npmto run prettier is fulfilled via the gradle-node-plugin.Related Issues
AI Disclosure