Skip to content

Add JavaScript prettier support to spotless tasks#7312

Open
kingthorin wants to merge 1 commit intozaproxy:mainfrom
kingthorin:js-format
Open

Add JavaScript prettier support to spotless tasks#7312
kingthorin wants to merge 1 commit intozaproxy:mainfrom
kingthorin:js-format

Conversation

@kingthorin
Copy link
Copy Markdown
Member

@kingthorin kingthorin commented Apr 27, 2026

Overview

Format JS scripts with Prettier via the Spotless Gradle plugin.

The dependency on npm to run prettier is fulfilled via the gradle-node-plugin.

Related Issues

AI Disclosure

  • Cursor was used in the preparation of this change.

@psiinon
Copy link
Copy Markdown
Member

psiinon commented Apr 27, 2026

Logo
Checkmarx One – Scan Summary & Detailsb554d583-d9ea-49b8-b429-a849aaca2c6f

Great job! No new security vulnerabilities introduced in this pull request


Use @Checkmarx to interact with Checkmarx PR Assistant.
Examples:
@Checkmarx how are you able to help me?
@Checkmarx rescan this PR

@kingthorin kingthorin force-pushed the js-format branch 6 times, most recently from c77b8ab to b580f77 Compare April 27, 2026 15:55
if (
item.match(/^-?[£\x24Û¢´€] ?\d/) || // prefixed currency
item.match(/^-?\d+\s*[€]/) || // suffixed currency
item.match(/^-?(\d+[,\.]?)+(E[\-+][\d]+)?%?$/) // number
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a pre-existing issue. We could arguably cap it at some number of digits. 🤷‍♂️

@kingthorin kingthorin marked this pull request as draft April 27, 2026 20:33
@kingthorin kingthorin force-pushed the js-format branch 7 times, most recently from 0d5ef6e to 7db2c0a Compare April 29, 2026 11:38
@kingthorin kingthorin marked this pull request as ready for review April 29, 2026 11:39
Signed-off-by: kingthorin <kingthorin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants