Skip to content

address comments

85521b2
Select commit
Loading
Failed to load commit list.
Open

Deterministic state syncs #2177

address comments
85521b2
Select commit
Loading
Failed to load commit list.
Claude / Claude Code Review completed Apr 6, 2026 in 35m 9s

Code review found 1 potential issue

Found 3 candidates, confirmed 1. See review comments for details.

Details

Severity Count
🔴 Important 0
🟡 Nit 1
🟣 Pre-existing 0
Severity File:Line Issue
🟡 Nit eth/ethconfig/config_test.go:52-57 Dead-code stubs GetBlockHeightByTime and StateSyncEventsAtHeight in test mocks after interface simplification

Annotations

Check warning on line 57 in eth/ethconfig/config_test.go

See this annotation in the file changed.

@claude claude / Claude Code Review

Dead-code stubs GetBlockHeightByTime and StateSyncEventsAtHeight in test mocks after interface simplification

Multiple test mock structs across 5 files implement `GetBlockHeightByTime` and `StateSyncEventsAtHeight` as extra methods that are not declared in either the `IHeimdallClient` or `Endpoint` interface, making these stubs unreachable dead code. These are leftovers from an earlier two-step design iteration (get Heimdall height, then fetch by height) that was replaced by the unified `StateSyncEventsByTime` call; removing them would avoid falsely implying that failover test coverage exists for an AtH