Skip to content

address comments

85521b2
Select commit
Loading
Failed to load commit list.
Open

Deterministic state syncs #2177

address comments
85521b2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Apr 6, 2026 in 1s

51.89% (-0.03%) compared to a1c5b22

View this Pull Request on Codecov

51.89% (-0.03%) compared to a1c5b22

Details

Codecov Report

❌ Patch coverage is 24.71910% with 134 lines in your changes missing coverage. Please review.
✅ Project coverage is 51.89%. Comparing base (a1c5b22) to head (85521b2).
⚠️ Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
consensus/bor/heimdallgrpc/state_sync.go 0.00% 53 Missing ⚠️
consensus/bor/heimdall/client.go 14.28% 42 Missing ⚠️
consensus/bor/heimdallapp/state_sync.go 0.00% 25 Missing ⚠️
tests/bor/mocks/IHeimdallClient.go 0.00% 11 Missing ⚠️
params/config.go 40.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2177      +/-   ##
===========================================
- Coverage    51.92%   51.89%   -0.03%     
===========================================
  Files          884      884              
  Lines       155431   155607     +176     
===========================================
+ Hits         80701    80752      +51     
- Misses       69524    69647     +123     
- Partials      5206     5208       +2     
Files with missing lines Coverage Δ
consensus/bor/bor.go 83.87% <100.00%> (+0.23%) ⬆️
consensus/bor/heimdall/failover_client.go 95.74% <100.00%> (+0.21%) ⬆️
consensus/bor/heimdall/metrics.go 12.50% <ø> (ø)
core/forkid/forkid.go 76.69% <100.00%> (+0.11%) ⬆️
params/config.go 36.84% <40.00%> (+0.02%) ⬆️
tests/bor/mocks/IHeimdallClient.go 0.00% <0.00%> (ø)
consensus/bor/heimdallapp/state_sync.go 0.00% <0.00%> (ø)
consensus/bor/heimdall/client.go 45.05% <14.28%> (-4.79%) ⬇️
consensus/bor/heimdallgrpc/state_sync.go 0.00% <0.00%> (ø)

... and 20 files with indirect coverage changes

Files with missing lines Coverage Δ
consensus/bor/bor.go 83.87% <100.00%> (+0.23%) ⬆️
consensus/bor/heimdall/failover_client.go 95.74% <100.00%> (+0.21%) ⬆️
consensus/bor/heimdall/metrics.go 12.50% <ø> (ø)
core/forkid/forkid.go 76.69% <100.00%> (+0.11%) ⬆️
params/config.go 36.84% <40.00%> (+0.02%) ⬆️
tests/bor/mocks/IHeimdallClient.go 0.00% <0.00%> (ø)
consensus/bor/heimdallapp/state_sync.go 0.00% <0.00%> (ø)
consensus/bor/heimdall/client.go 45.05% <14.28%> (-4.79%) ⬇️
consensus/bor/heimdallgrpc/state_sync.go 0.00% <0.00%> (ø)

... and 20 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.