consensus/bor, internal/cli: full grpc implementation #2194
Claude / Claude Code Review
completed
May 6, 2026 in 25m 49s
Code review found 1 important issue
Found 3 candidates, confirmed 2. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 1 |
| 🟡 Nit | 1 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🔴 Important | cmd/keeper/go.sum:170 |
cmd/keeper/go.sum missing h1 hash for golang.org/x/sys v0.42.0 — build fails |
| 🟡 Nit | internal/cli/server/api_service.go:113-115 |
mapBorAPIError misses errReorgDuringRootComputation and errNonContiguousHeaderRange sentinels |
Annotations
Check failure on line 170 in cmd/keeper/go.sum
claude / Claude Code Review
cmd/keeper/go.sum missing h1 hash for golang.org/x/sys v0.42.0 — build fails
The PR bumps `cmd/keeper/go.mod` to `golang.org/x/sys v0.42.0` but only adds the matching `/go.mod` hash to `cmd/keeper/go.sum` — the corresponding `h1:` source hash is missing, so `go build ./...` from `cmd/keeper` fails with `missing go.sum entry for module providing package golang.org/x/sys/unix`. cmd/keeper has no CI workflow so this doesn't block the PR's pipeline, but it breaks anyone following `cmd/keeper/README.md`. Fix is one line: insert `golang.org/x/sys v0.42.0 h1:omrd2nAlyT5ESRdCLYd
Check warning on line 115 in internal/cli/server/api_service.go
claude / Claude Code Review
mapBorAPIError misses errReorgDuringRootComputation and errNonContiguousHeaderRange sentinels
The new `mapBorAPIError` helper at internal/cli/server/api_service.go:80-115 misses two package-private sentinel errors that `bor.API.GetRootHash` returns: `errReorgDuringRootComputation` ("reorg occurred while computing checkpoint root", consensus/bor/bor.go:125, returned at api.go:355) and `errNonContiguousHeaderRange` ("non-contiguous headers in checkpoint range", consensus/bor/bor.go:129, returned at api.go:373). Both fall through to the default `codes.Internal` branch. The reorg case is the
Loading