Skip to content

consensus/bor, internal/cli: full grpc implementation #2194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marcello33 wants to merge 16 commits into
base: develop
Choose a base branch
from

internal/cli: address comments and add new tests

f980175
Select commit
Loading
Failed to load commit list.
Open

consensus/bor, internal/cli: full grpc implementation #2194

internal/cli: address comments and add new tests
f980175
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 6, 2026 in 0s

52.49% (+0.20%) compared to 1bf990d

View this Pull Request on Codecov

52.49% (+0.20%) compared to 1bf990d

Details

Codecov Report

❌ Patch coverage is 77.42718% with 93 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.49%. Comparing base (1bf990d) to head (f980175).

Files with missing lines Patch % Lines
internal/cli/server/api_service.go 72.22% 54 Missing and 16 partials ⚠️
internal/cli/server/server.go 87.20% 9 Missing and 2 partials ⚠️
internal/cli/server/command.go 30.00% 6 Missing and 1 partial ⚠️
consensus/bor/bor.go 44.44% 4 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2194      +/-   ##
===========================================
+ Coverage    52.29%   52.49%   +0.20%     
===========================================
  Files          884      884              
  Lines       155571   155943     +372     
===========================================
+ Hits         81355    81869     +514     
+ Misses       68989    68817     -172     
- Partials      5227     5257      +30
Files with missing lines Coverage Δ
consensus/bor/api.go 86.12% <ø> (ø)
internal/cli/command.go 20.07% <100.00%> (+8.91%) ⬆️
internal/cli/server/config.go 63.87% <ø> (ø)
internal/cli/server/flags.go 100.00% <100.00%> (ø)
internal/cli/server/utils.go 100.00% <100.00%> (+100.00%) ⬆️
consensus/bor/bor.go 85.06% <44.44%> (-0.30%) ⬇️
internal/cli/server/command.go 37.70% <30.00%> (-0.45%) ⬇️
internal/cli/server/server.go 56.64% <87.20%> (+26.11%) ⬆️
internal/cli/server/api_service.go 72.58% <72.22%> (+72.58%) ⬆️

... and 17 files with indirect coverage changes

Files with missing lines Coverage Δ
consensus/bor/api.go 86.12% <ø> (ø)
internal/cli/command.go 20.07% <100.00%> (+8.91%) ⬆️
internal/cli/server/config.go 63.87% <ø> (ø)
internal/cli/server/flags.go 100.00% <100.00%> (ø)
internal/cli/server/utils.go 100.00% <100.00%> (+100.00%) ⬆️
consensus/bor/bor.go 85.06% <44.44%> (-0.30%) ⬇️
internal/cli/server/command.go 37.70% <30.00%> (-0.45%) ⬇️
internal/cli/server/server.go 56.64% <87.20%> (+26.11%) ⬆️
internal/cli/server/api_service.go 72.58% <72.22%> (+72.58%) ⬆️

... and 17 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
View more details on Codecov