Refactor FATES interface to directly pass to fates patch data structure#7482
Closed
glemieux wants to merge 124 commits intoE3SM-Project:masterfrom
Closed
Refactor FATES interface to directly pass to fates patch data structure#7482glemieux wants to merge 124 commits intoE3SM-Project:masterfrom
glemieux wants to merge 124 commits intoE3SM-Project:masterfrom
Conversation
github-project-automation
Bot
moved this to Finding Reviewers
in FATES Pull Request Planning and Status
glemieux
force-pushed
the
lnd/fates-bc-refactor-patch-direct
branch
2 times, most recently
from
46dd1ae to
7e99bd1
Compare
5 tasks
glemieux
force-pushed
the
lnd/fates-bc-refactor-patch-direct
branch
from
cdb63c5 to
b391bcf
Compare
glemieux
force-pushed
the
lnd/fates-bc-refactor-patch-direct
branch
from
dfcf8fd to
4a81700
Compare
Contributor
Author
|
FYI @peterdschwartz this is essentially ready and waiting on NGEET/fates#1477. I'll update the description before marking ready for review. |
5 tasks
These have moved into fates
… can/should take place during init_coldstart instead of init This will mostly be the non-global data type variables
Since we pass vert_soilc namelist tag, we can replace this init_soil_depths logic on the fates side
This reverts commit a781bbf.
glemieux
force-pushed
the
lnd/fates-bc-refactor-patch-direct
branch
from
bfbd7fb to
3932407
Compare
Member
|
Closing draft PRs with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated fates pull request: NGEET/fates#1477