JSON formatted FATES parameters#7954
Conversation
|
This must come in after FATES 1493. |
|
RGK: THIS IS COMPLETE This should come in before #7482 |
|
Regression testing the |
|
Regression testing with the e3sm land developer tests against @peterdschwartz during integration testing, will this get tested on different machines? @rgknox and I are curious if there will be any issues that crop up with testing on a different machine. |
|
Yes the overnight testing will run on several machines. What compiler did you use on perlmutter? Different compilers usually expose problems more then different machines. |
Thanks @rljacob. I used the gnu and intel compilers on |
|
@peterdschwartz I realized I actually made a mistake during regression testing. Please hold off on integrating for now. Apologies. |
|
@peterdschwartz I've rerun the testing with the correct fates tag (which has been updated and pushed here). I'm seeing expected DIFFs on fates test with the exception of the Results: |
|
Is this ready? |
@rljacob yes |
|
@peterdschwartz please start merging this. |
|
Tested the branch on chrysalis and everything worked as expected so will merge today. Expecting these DIFFs |
This set of changes introduces a format change for FATES parameters from netcdf to JSON. These changes were introduced for various reasons, see explanation in FATES PR 1493. [non-BFB] for FATES
|
on next |
This set of changes introduces a format change for FATES parameters from netcdf to JSON. These changes were introduced for various reasons, see explanation in FATES PR 1493.
[non-BFB] for FATES