Skip to content

JSON formatted FATES parameters#7954

Merged
peterdschwartz merged 3 commits into
E3SM-Project:masterfrom
rgknox:fates-json
Feb 27, 2026
Merged

JSON formatted FATES parameters#7954
peterdschwartz merged 3 commits into
E3SM-Project:masterfrom
rgknox:fates-json

Conversation

@rgknox
Copy link
Copy Markdown
Contributor

@rgknox rgknox commented Dec 18, 2025

This set of changes introduces a format change for FATES parameters from netcdf to JSON. These changes were introduced for various reasons, see explanation in FATES PR 1493.

[non-BFB] for FATES

@rgknox
Copy link
Copy Markdown
Contributor Author

rgknox commented Dec 18, 2025

This must come in after FATES 1493.
NGEET/fates#1493

@rgknox rgknox added wip work in progress enhancement FATES ELM land model labels Dec 18, 2025
@rljacob rljacob marked this pull request as draft December 18, 2025 17:43
@rgknox rgknox removed the wip work in progress label Feb 2, 2026
@rgknox rgknox marked this pull request as ready for review February 2, 2026 19:41
@rljacob rljacob requested a review from glemieux February 4, 2026 01:44
@glemieux glemieux moved this from Finding Reviewers to Under Review in FATES Pull Request Planning and Status Feb 5, 2026
@glemieux
Copy link
Copy Markdown
Contributor

glemieux commented Feb 5, 2026

RGK: THIS IS COMPLETE This should come in after #7899. NGEET/fates#1493 has been integrated into FATES.

This should come in before #7482

@glemieux
Copy link
Copy Markdown
Contributor

Regression testing the e3sm_land_developer against the master baseline is underway on pm-cpu.

@glemieux glemieux moved this from Under Review to Final Testing in FATES Pull Request Planning and Status Feb 17, 2026
@glemieux
Copy link
Copy Markdown
Contributor

Regression testing with the e3sm land developer tests against master are B4B on perlmutter with the expected NLCOMP exception in the fates mod due to the change in the fates parameter file name change.

@peterdschwartz during integration testing, will this get tested on different machines? @rgknox and I are curious if there will be any issues that crop up with testing on a different machine.

@glemieux glemieux moved this from Final Testing to Ready to Integrate in FATES Pull Request Planning and Status Feb 17, 2026
@rljacob
Copy link
Copy Markdown
Member

rljacob commented Feb 17, 2026

Yes the overnight testing will run on several machines. What compiler did you use on perlmutter? Different compilers usually expose problems more then different machines.

@glemieux
Copy link
Copy Markdown
Contributor

Yes the overnight testing will run on several machines. What compiler did you use on perlmutter? Different compilers usually expose problems more then different machines.

Thanks @rljacob. I used the gnu and intel compilers on pm-cpu.

@glemieux
Copy link
Copy Markdown
Contributor

@peterdschwartz I realized I actually made a mistake during regression testing. Please hold off on integrating for now. Apologies.

@glemieux glemieux moved this from Ready to Integrate to Final Testing in FATES Pull Request Planning and Status Feb 17, 2026
@glemieux
Copy link
Copy Markdown
Contributor

glemieux commented Feb 18, 2026

@peterdschwartz I've rerun the testing with the correct fates tag (which has been updated and pushed here). I'm seeing expected DIFFs on fates test with the exception of the fates_satphen test which is B4B as expected. The diffs are due to updating the tag to a newer version of fates which includes answer changing bug fixes.

Results: /global/homes/g/glemieux/scratch/e3sm-tests/pr7954-eld-sci1901.fates.pm-cpu..E79f1841d16-F55ec6c776

@rljacob
Copy link
Copy Markdown
Member

rljacob commented Feb 24, 2026

Is this ready?

@glemieux
Copy link
Copy Markdown
Contributor

Is this ready?

@rljacob yes

@peterdschwartz peterdschwartz added the non-BFB PR makes roundoff changes to answers. label Feb 24, 2026
@rljacob
Copy link
Copy Markdown
Member

rljacob commented Feb 26, 2026

@peterdschwartz please start merging this.

@peterdschwartz
Copy link
Copy Markdown
Contributor

Tested the branch on chrysalis and everything worked as expected so will merge today. Expecting these DIFFs

>>> ./cs.status.20260225_082331_xxphhs | grep "Overall: DIFF"
  ERS_D_Ld15.f45_g37.IELMFATES.chrysalis_intel.elm-fates_cold_treedamage (Overall: DIFF) details:
  ERS_Ld20.f45_f45.IELMFATES.chrysalis_intel.elm-fates (Overall: DIFF) details:
  SMS_D_Ld20.f45_f45.IELMFATES.chrysalis_intel.elm-fates_rd (Overall: DIFF) details:
  SMS_Ld20.f45_f45.IELMFATES.chrysalis_intel.elm-fates_eca (Overall: DIFF) details:
  SMS_Ld5_PS.f19_g16.IELMFATES.chrysalis_intel.elm-fates_cold (Overall: DIFF) details:

peterdschwartz added a commit that referenced this pull request Feb 26, 2026
This set of changes introduces a format change for FATES parameters from netcdf to JSON. These changes were introduced for various reasons, see explanation in FATES PR 1493.

[non-BFB] for FATES
@peterdschwartz
Copy link
Copy Markdown
Contributor

on next

@peterdschwartz peterdschwartz merged commit fed063b into E3SM-Project:master Feb 27, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ELM land model enhancement FATES non-BFB PR makes roundoff changes to answers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants