feat: add auto-generated enums for HIPO schema #1205
Open
baltzell wants to merge 12 commits into
Open
Conversation
baltzell
force-pushed
the
bank-enums
branch
3 times, most recently
from
29cfe40 to
ca90c21
Compare
c-dilks
reviewed
May 14, 2026
| <goals> | ||
| <goal>run</goal> | ||
| </goals> | ||
| <inherited>false</inherited> <!-- make this one NOT inherited --> |
Member
There was a problem hiding this comment.
Instead of preventing inheritance, could you just move this plugin to common-tools/clas-io? There it would be closer to its generated Java code artifacts.
Member
There was a problem hiding this comment.
If you move the plugin to common-tools/clas-io, you could also move this script to common-tools/clas-io/ too; no need for it to live in libexec since this script is only needed at build time.
Comment on lines
+455
to
+470
| <!-- delete auto-generated bank schema enums during clean phase --> | ||
| <plugin> | ||
| <artifactId>maven-clean-plugin</artifactId> | ||
| <version>3.4.0</version> | ||
| <configuration> | ||
| <filesets> | ||
| <fileset> | ||
| <directory>common-tools/clas-io/src/main/java/org/jlab/io/banks</directory> | ||
| <includes> | ||
| <include>**/*.java</include> | ||
| </includes> | ||
| </fileset> | ||
| </filesets> | ||
| </configuration> | ||
| </plugin> | ||
|
|
Member
There was a problem hiding this comment.
same here, this could be moved to common-tools/clas-io.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.