-
Notifications
You must be signed in to change notification settings - Fork 32
feat: add auto-generated enums for HIPO schema #1205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
baltzell
wants to merge
13
commits into
development
Choose a base branch
from
bank-enums
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+60
−0
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
91b0766
add script to generate enums from bank schema
baltzell 6828523
add resulting enums
baltzell 306fb91
cleanup
baltzell e5565d8
update package name
baltzell bfc5b86
update bank package path
baltzell 37fc38d
remove auto-generated bank schema enums
baltzell 27a4d42
rename
baltzell a00473e
remove auto-generated bank enums (again?)
baltzell 1231be5
gitignore auto-generated bank enums
baltzell 59a0b71
add schema-enum-cleaning to mvn clean
baltzell ec8a792
add bank schema enum generation to maven validation phase
baltzell d88d5d3
switch to single underscore
baltzell b42c0e4
move enum build to clas-io
baltzell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| #!/usr/bin/env python3 | ||
| import os,glob,json | ||
| top = os.path.normpath(os.path.dirname(os.path.abspath(__file__))+'/..') | ||
| idir = top+'/etc/bankdefs/hipo4' | ||
| odir = top+'/common-tools/clas-io/src/main/java/org/jlab/io/banks' | ||
| print(f'INFO: Creating schema enums at {odir}') | ||
| os.makedirs(odir, exist_ok=True) | ||
| for x in glob.glob(f'{idir}/*.json'): | ||
| for bank in json.load(open(x,'r')): | ||
| class_name = bank['name'].replace('::','_').replace(':','_') | ||
| with open(f'{odir}/{class_name}.java','w') as f: | ||
| f.write('package org.jlab.io.banks;\n') | ||
| f.write(f'public class {class_name} {{\n') | ||
| for i,entry in enumerate(bank['entries']): | ||
| var_name = entry['name'] | ||
| f.write(f' public static final short {var_name} = {i};\n') | ||
| f.write('}\n') | ||
| f.close() |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.