Adding some more land-use-change and globally-relevant history variables#1485
Merged
Conversation
…r LUC-associated fire
github-project-automation
Bot
moved this to Finding Reviewers
in FATES Pull Request Planning and Status
glemieux
added
the
software: history output
Contributor
5 tasks
5 tasks
glemieux
reviewed
Feb 8, 2026
Contributor
|
After applying the suggested fixes above, I'm getting B4B results against the current baseline, but I'm seeing the Here's the top part of the error output: More of the output can be found in the case output here: |
Contributor
I determined that I accidentally introduced an error when I applied 632a127. This is corrected via 2680f31. |
Contributor
|
Regression testing against Results: |
glemieux
approved these changes
Feb 12, 2026
glemieux
moved this from Finding Reviewers
to Ready to Integrate
in FATES Pull Request Planning and Status
glemieux
moved this from Ready to Integrate
to Under Review
in FATES Pull Request Planning and Status
glemieux
reviewed
Feb 13, 2026
Comment on lines
+3025
to
+3028
| if (((ccohort%c_area + crown_area_covered)/cpatch%area) .ge. 0.05_r8 ) then | ||
| hio_patch_weighted_95thpctile_height_si(io_si) = & | ||
| hio_patch_weighted_95thpctile_height_si(io_si) + ccohort%height * cpatch%area/AREA | ||
| ccohort => null() ! exit the cohort loop |
Contributor
There was a problem hiding this comment.
Linking @rgknox comment here: #1529 (comment) since I'm closing #1529
github-project-automation
Bot
moved this from Under Review
to Ready to Integrate
in FATES Pull Request Planning and Status
peterdschwartz
added a commit
to E3SM-Project/E3SM
that referenced
this pull request
Mar 24, 2026
This pull request passes HLM biophysical landuse variables into fates to by output as diagnostic variables along FATES dimensions. Thefates_cold_luh2 test mod is updated to include these new diagnostic variables. This also updates the fates_cold_allvars testmod to include new history variables added with NGEET/fates#1485. This PR is the ELM-side code changes associated with FATES PR NGEET/fates#1536. [B4B]
peterdschwartz
added a commit
to E3SM-Project/E3SM
that referenced
this pull request
Mar 25, 2026
This pull request passes HLM biophysical landuse variables into fates to by output as diagnostic variables along FATES dimensions. Thefates_cold_luh2 test mod is updated to include these new diagnostic variables. This also updates the fates_cold_allvars testmod to include new history variables added with NGEET/fates#1485. This PR is the ELM-side code changes associated with FATES PR NGEET/fates#1536. [non-BFB] for FATES due to field lists
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a few variables that I wanted to use for the TRENDY runs and/or global calibration.
Description:
These new variables include:
In the interest of cleanup, this PR also gets rid of a few history variables:
Collaborators:
@mpaiao, @JessicaNeedham
Expectation of Answer Changes:
should not be answer-changing except for the different variables (though perhaps roundoff level changes to fire and downstream fluxes like NBP because order of operations changed?)
Checklist
If this is your first time contributing, please read the CONTRIBUTING document.
All checklist items must be checked to enable merging this pull request:
Contributor
Integrator
If satellite phenology regressions are not b4b, please hold merge and notify the FATES development team.
Documentation
Test Results:
Not yet tested here. I cherry-picked all of these from my working branch, so it is possible there are conflicts that I didn't catch.
CTSM (or) E3SM (specify which) test hash-tag:
CTSM (or) E3SM (specify which) baseline hash-tag:
FATES baseline hash-tag:
Test Output: