CAM computes enthalpy to send to BLOM#2
Open
mvertens wants to merge 6 commits into
Open
Conversation
This was referenced Oct 9, 2025
gold2718
requested changes
Oct 13, 2025
gold2718
left a comment
gold2718
left a comment
There was a problem hiding this comment.
This is basically okay but could use some cleanup. Suggested cleanup PR coming to this branch.
| ! | ||
| !---------------------------Local workspace----------------------------- | ||
| ! | ||
| integer :: i,k,m ! Longitude, level indices |
There was a problem hiding this comment.
In new code, it would be nice to use multi-character variable names.
|
|
||
| !---------------------------Local workspace----------------------------- | ||
|
|
||
| integer :: i,k,m, ixq ! Longitude, level indices |
There was a problem hiding this comment.
Same issue with single-digit variable names.
Comment on lines
+487
to
+488
| tot_water(:ncol,1) = qini(:ncol,k)+liqini(:ncol,k)+iceini(:ncol,k) !initial total H2O | ||
| tot_water(:ncol,2) = 0.0_r8 |
There was a problem hiding this comment.
This would be clearer as two separate work arrays, tot_water_init and tot_water_present.
| real(r8) :: condcp(pcols,pver) ! species-increment-weighted cp | ||
| real(r8) :: pint_old(pcols,pver+1) ! work array | ||
| real(r8) :: dummy(pcols,pver) ! work array | ||
| integer :: is_invalid(pcols) |
There was a problem hiding this comment.
This should be a logical, maybe has_dcwat would be clearer..
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
New routine
schemes/conservation_adjust/dme_adjust/dme_adjust_camnor.F90that is needed to enable the changes introduced from Thomas Toniazzo.Specific notes
Issues Fixed:
Are changes expected to change answers? (specify if BFB, different at roundoff, more substantial)
Any User Interface Changes (namelist or namelist defaults changes)?
Testing performed
Please describe the tests along with the target model and machine(s)
If possible, please also added hashes that were used in the testing
List all automated tests that failed, as well as an explanation for why they weren't fixed: