Skip to content

Serialize Azure managed disk attachments #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mpagot wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Serialize Azure managed disk attachments #455

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions terraform/azure/modules/hana_node/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,11 +376,19 @@ resource "azurerm_managed_disk" "hana_data_disk" {
}

resource "azurerm_virtual_machine_data_disk_attachment" "hana_data_disk_attachment" {
count = var.hana_count * local.disks_number
managed_disk_id = azurerm_managed_disk.hana_data_disk[count.index].id
virtual_machine_id = azurerm_linux_virtual_machine.hana[floor(count.index / local.disks_number)].id
lun = count.index % local.disks_number
caching = element(local.disks_caching, count.index % local.disks_number)
count = var.hana_count * local.disks_number
managed_disk_id = azurerm_managed_disk.hana_data_disk[count.index].id
# Chain attachments per-VM: each disk attachment (except the first for each VM) depends
# on the previous one via virtual_machine_id. This forces Terraform to serialize disk
# attach operations on the same VM, preventing Azure 409 ConflictingConcurrentWriteNotAllowed
# errors even when -parallelism=1 is not reliably enforced. See TEAM-11065.md.
virtual_machine_id = (
count.index % local.disks_number == 0
? azurerm_linux_virtual_machine.hana[floor(count.index / local.disks_number)].id
: azurerm_virtual_machine_data_disk_attachment.hana_data_disk_attachment[count.index - 1].virtual_machine_id
)
lun = count.index % local.disks_number
caching = element(local.disks_caching, count.index % local.disks_number)
timeouts {
read = "30m"
}
Expand Down
Loading