fix(MacOS CI): enable run on Mac OS#874
Merged
yangxk1 merged 4 commits intoapache:mainfrom Feb 25, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #874 +/- ##
=========================================
Coverage 80.21% 80.21%
Complexity 615 615
=========================================
Files 93 93
Lines 10255 10255
Branches 1049 1049
=========================================
Hits 8226 8226
Misses 1789 1789
Partials 240 240
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SYaoJun
force-pushed
the
224_mac_ci
branch
2 times, most recently
from
087f998 to
22d7106
Compare
Contributor
Author
|
|
Contributor
Author
|
fix: #873 |
SYaoJun
commented
Feb 24, 2026
| set(CMAKE_MODULE_PATH ${CMAKE_CURRENT_SOURCE_DIR}/cmake) | ||
| include_directories(${CMAKE_CURRENT_SOURCE_DIR}) | ||
| add_library(${PROJECT_NAME} INTERFACE) | ||
| target_compile_features(${PROJECT_NAME} INTERFACE cxx_std_17) |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
…n Apache-Arrow version
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables macOS CI builds by introducing dynamic C++ standard selection based on Apache Arrow version. The main issue being addressed is that Arrow 23.0.0+ requires C++20, while earlier versions can use C++17. The changes make the C++ standard configurable and automatically adapt to the Arrow version being used.
Changes:
- Introduced
GAR_CXX_STANDARDvariable (default 17) that dynamically updates to 20 when Arrow >= 23.0.0 is detected or built - Removed hardcoded
-std=c++17from CMAKE_CXX_FLAGS and interface library target features, replaced with per-targetcxx_std_${GAR_CXX_STANDARD}configuration - Added
brew list --versionsto macOS CI workflow for better debugging visibility
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| cpp/CMakeLists.txt | Introduces GAR_CXX_STANDARD variable and dynamic C++ standard selection based on Arrow version; updates all target_compile_features to use the variable; removes hardcoded C++17 flags |
| .github/workflows/ci.yml | Adds brew package version listing for debugging in macOS CI |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Jason <libevent@yeah.net>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Jason <libevent@yeah.net>
Signed-off-by: syaojun <libevent@yeah.net>
yangxk1
pushed a commit
to SYaoJun/incubator-graphar
that referenced
this pull request
Feb 25, 2026
* fix(CI): Enable CI run success on Mac OS, change C++ standard based on Apache-Arrow version * Update cpp/CMakeLists.txt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Jason <libevent@yeah.net> * Update cpp/CMakeLists.txt Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Jason <libevent@yeah.net> * chore: remove unnecessary comments Signed-off-by: syaojun <libevent@yeah.net> --------- Signed-off-by: Jason <libevent@yeah.net> Signed-off-by: syaojun <libevent@yeah.net> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for this PR
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?