Conversation
…L on Ubuntu to provide auth mechanisms required for tests
3 tasks
Contributor
Author
|
Failure example for the SASL tests due to missing related auth mechanisms is as follows (from #2293): |
acelyc111
approved these changes
Sep 19, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR adds the libsasl2-modules package to Ubuntu Docker build environments to enable SASL authentication mechanisms required for ZooKeeper connectivity tests.
- Installs pluggable authentication modules for Cyrus SASL across all Ubuntu versions
- Ensures test compatibility with SASL-enabled ZooKeeper connections
- Maintains consistency across Ubuntu 18.04, 20.04, and 22.04 build environments
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docker/pegasus-build-env/ubuntu1804/Dockerfile | Adds libsasl2-modules package to Ubuntu 18.04 build environment |
| docker/pegasus-build-env/ubuntu2004/Dockerfile | Adds libsasl2-modules package to Ubuntu 20.04 build environment |
| docker/pegasus-build-env/ubuntu2204/Dockerfile | Adds libsasl2-modules package to Ubuntu 22.04 build environment |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Samunroyu
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2292
To support tests that connect to ZooKeeper via SASL, auth modules should be
introduced. Otherwise, those tests would fail due to missing necessary mechanisms.