Support partial metadata based aggregation when some projection aggregations are not metadata compatible#18334
Open
adasari wants to merge 1 commit into
Open
Conversation
…gations are not metadata compatible
Author
|
@Jackie-Jiang Please let me know your thoughts on the changes. I’ll add unit and integration tests once the approach is confirmed. thanks in advance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Metadata-based aggregation is currently applied only when all projection aggregation functions are metadata-compatible.
If even one aggregation function in the projection is not metadata-based, the query engine falls back to scan-based execution for all aggregations, including those that could have been computed using metadata.
This results in missed optimization opportunities and unnecessary full segment scans.
Eg:
This PR adds partial metadata based aggregations for aggregation plan node only.
Pending: