Skip to content

Support partial metadata based aggregation when some projection aggregations are not metadata compatible #18334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
adasari wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support partial metadata based aggregation when some projection aggregations are not metadata compatible #18334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion pinot-core/src/main/java/org/apache/pinot/core/operator/query/AggregationOperator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,13 +51,20 @@ public class AggregationOperator extends BaseOperator<AggregationResultsBlock> {
private final long _numTotalDocs;

private int _numDocsScanned = 0;
protected final Object[] _preAggregatedResults;

public AggregationOperator(QueryContext queryContext, AggregationInfo aggregationInfo, long numTotalDocs) {
this(queryContext, aggregationInfo, numTotalDocs, null);
}

public AggregationOperator(QueryContext queryContext, AggregationInfo aggregationInfo, long numTotalDocs,
Object[] preAggregatedResults) {
_queryContext = queryContext;
_aggregationFunctions = queryContext.getAggregationFunctions();
_projectOperator = aggregationInfo.getProjectOperator();
_useStarTree = aggregationInfo.isUseStarTree();
_numTotalDocs = numTotalDocs;
_preAggregatedResults = preAggregatedResults;
}

@Override
Expand All @@ -67,7 +74,7 @@ protected AggregationResultsBlock getNextBlock() {
if (_useStarTree) {
aggregationExecutor = new StarTreeAggregationExecutor(_aggregationFunctions);
} else {
aggregationExecutor = new DefaultAggregationExecutor(_aggregationFunctions);
aggregationExecutor = new DefaultAggregationExecutor(_aggregationFunctions, _preAggregatedResults);
}
ValueBlock valueBlock;
while ((valueBlock = _projectOperator.nextBlock()) != null) {
Expand Down
Loading