Make concurrent-scheduling dispatch helpers protected for subclass extension#18431
Merged
raghavyadav01 merged 2 commits intoapache:masterfrom May 7, 2026
Merged
Conversation
…tension Bumps PinotTaskManager#shouldUseConcurrentPath and #resolveConcurrentScheduling from package-private @VisibleForTesting to protected @VisibleForTesting so that subclasses in other packages can integrate with the concurrent scheduling path introduced in apache#18272. In particular, this lets a subclass override resolveConcurrentScheduling to plug in a different per-table policy (for example, defaulting concurrent scheduling to true for specific task types) and have its override invoked from the parent's shouldUseConcurrentPath. Without this change, a different-package subclass cannot polymorphically override the package-private resolver — Java treats the same-named method as hidden rather than overridden — so the extension hook is effectively unreachable. No behavioral change. The methods retain @VisibleForTesting; existing same- package tests continue to work unchanged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
noob-se7en
added
extension-point
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #18431 +/- ##
============================================
- Coverage 63.59% 63.57% -0.02%
Complexity 1717 1717
============================================
Files 3252 3252
Lines 199119 199119
Branches 30857 30857
============================================
- Hits 126627 126590 -37
- Misses 62425 62452 +27
- Partials 10067 10077 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shounakmk219
approved these changes
May 7, 2026
Contributor
Author
|
@swaminathanmanish @xiangfu0 @Jackie-Jiang pls help with merge |
raghavyadav01
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bump
PinotTaskManager#shouldUseConcurrentPathand#resolveConcurrentSchedulingfrom package-private@VisibleForTestingtoprotected @VisibleForTesting, so subclasses in other packages can integrate with the concurrent scheduling path introduced in #18272.