Skip to content

Make concurrent-scheduling dispatch helpers protected for subclass extension #18431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raghavyadav01 merged 2 commits into from
May 7, 2026
+2 −4
Merged

Make concurrent-scheduling dispatch helpers protected for subclass extension #18431

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b20fe3
Make concurrent-scheduling dispatch helpers protected for subclass ex…
noob-se7en May 6, 2026
ba7efd2
Removes visibleForTesting
noob-se7en May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions ...troller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -780,8 +780,7 @@ public Map<String, TaskSchedulingInfo> scheduleTasks(TaskSchedulingContext conte
* If no specific tables are targeted (i.e., "schedule for every table"), the check iterates the full
* table list so that per-table opt-outs are still honored.
*/
@VisibleForTesting
boolean shouldUseConcurrentPath(TaskSchedulingContext context) {
protected boolean shouldUseConcurrentPath(TaskSchedulingContext context) {
Set<String> targetTables = context.getTablesToSchedule();
Set<String> targetDatabases = context.getDatabasesToSchedule();
Set<String> consolidatedTables = new HashSet<>();
Expand Down Expand Up @@ -814,8 +813,7 @@ boolean shouldUseConcurrentPath(TaskSchedulingContext context) {
* Resolves the effective concurrent-scheduling flag for a single table: table-level override if
* set, otherwise the cluster-level default.
*/
@VisibleForTesting
boolean resolveConcurrentScheduling(TableConfig tableConfig) {
protected boolean resolveConcurrentScheduling(TableConfig tableConfig) {
TableTaskConfig taskConfig = tableConfig.getTaskConfig();
if (taskConfig != null) {
Boolean tableFlag = taskConfig.getConcurrentSchedulingEnabled();
Expand Down
Loading