[Java] Remove AWS SDK v1 STS dependency from serializer-deserializer#503
[Java] Remove AWS SDK v1 STS dependency from serializer-deserializer#503jvdadda wants to merge 1 commit intoawslabs:masterfrom
Conversation
The v2 STS dependency (software.amazon.awssdk:sts) is already present. Also update Javadoc references from AWSCredentialsProvider to AwsCredentialsProvider.
There was a problem hiding this comment.
Pull request overview
This PR removes the AWS SDK v1 STS dependency (com.amazonaws:aws-java-sdk-sts) from the serializer-deserializer module, as part of the broader effort to fully remove AWS Java SDK v1 references (issue #500). The v2 equivalent (software.amazon.awssdk:sts) was already declared and no v1 STS classes were used in the source code. Additionally, Javadoc comments referencing the v1 class name AWSCredentialsProvider are updated to the v2 name AwsCredentialsProvider.
Changes:
- Removed the
com.amazonaws:aws-java-sdk-stsdependency fromserializer-deserializer/pom.xml - Updated Javadoc comments in
AWSKafkaAvroDeserializerandGlueSchemaRegistryKafkaDeserializerto referenceAwsCredentialsProviderinstead ofAWSCredentialsProvider - Updated corresponding test comments to match the new class name
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| serializer-deserializer/pom.xml | Removed AWS SDK v1 STS dependency |
| serializer-deserializer/src/main/java/.../AWSKafkaAvroDeserializer.java | Updated Javadoc to reference AwsCredentialsProvider |
| serializer-deserializer/src/main/java/.../GlueSchemaRegistryKafkaDeserializer.java | Updated Javadoc to reference AwsCredentialsProvider |
| serializer-deserializer/src/test/java/.../AWSKafkaAvroDeserializerTest.java | Updated test comment to reference AwsCredentialsProvider |
| serializer-deserializer/src/test/java/.../GlueSchemaRegistryKafkaDeserializerTest.java | Updated test comment to reference AwsCredentialsProvider |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Issue #, if available: #500
Description of changes:
Remove the
com.amazonaws:aws-java-sdk-sts(AWS SDK v1) dependency from theserializer-deserializermodule. The v2 equivalentsoftware.amazon.awssdk:stsis already declared and no v1 STS classes are used in source code.Also updates Javadoc comments referencing the v1 class name
AWSCredentialsProviderto the v2 nameAwsCredentialsProvider.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.