yarn2npm#5080
Open
haslinghuis wants to merge 5 commits intobetaflight:masterfrom
Open
Conversation
Contributor
WalkthroughCI workflows, README, .gitignore, and package.json were migrated from Yarn to npm: workflows now use ChangesYarn → npm migration
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/tauri-nightly.yml (1)
250-258:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winAndroid job's
Setup Nodestep is missingcache: npm.The
desktopjob (Line 94) specifiescache: npminactions/setup-node, but theandroidjob omits it. This means the Android build skips npm caching entirely and will re-download all packages on every run.⚙️ Proposed fix
- name: Setup Node uses: actions/setup-node@v5 with: node-version-file: .nvmrc + cache: npm🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/tauri-nightly.yml around lines 250 - 258, The Android job's "Setup Node" step uses actions/setup-node@v5 but omits the npm cache option, causing no npm caching; update the "Setup Node" step in the Android job to include the cache: npm option (same pattern used in the desktop job) so actions/setup-node@v5 is invoked with node-version-file: .nvmrc and cache: npm to enable npm package caching for the Android workflow steps (npm ci, npm run build, node capacitor.config.generator.mjs, npx cap sync android).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@package.json`:
- Around line 87-90: The Storybook deps are version-mismatched:
`@storybook/addon-actions` is v9 while `@storybook/addon-essentials`,
`@storybook/addon-links` and `@storybook/vue3` are v8; fix by choosing one of two
actions—either revert `@storybook/addon-actions` to a compatible ^8.x to stay on
Storybook v8, or migrate fully to v9 by removing `@storybook/addon-essentials`
from package.json (its features are core in v9) and upgrading
`@storybook/addon-actions` and `@storybook/vue3` to ^9.x (keep
`@storybook/addon-links` only if you still need it); after editing the
package.json dependencies run the package manager install and verify Storybook
starts to confirm the chosen path.
In `@README.md`:
- Line 158: Update the README instruction to forward the host flag to the
underlying Vite process by using the double-dash separator: replace the current
usage of "npm run dev --host" with "npm run dev -- --host" (or alternatively
instruct to run "npx vite --host"); ensure the README text that references `npm
run dev --host` and `vite` is updated so readers know to include `--` to forward
args to Vite.
---
Outside diff comments:
In @.github/workflows/tauri-nightly.yml:
- Around line 250-258: The Android job's "Setup Node" step uses
actions/setup-node@v5 but omits the npm cache option, causing no npm caching;
update the "Setup Node" step in the Android job to include the cache: npm option
(same pattern used in the desktop job) so actions/setup-node@v5 is invoked with
node-version-file: .nvmrc and cache: npm to enable npm package caching for the
Android workflow steps (npm ci, npm run build, node
capacitor.config.generator.mjs, npx cap sync android).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 52ce0444-cc71-42a6-aa41-d781c5ec39ea
⛔ Files ignored due to path filters (2)
package-lock.jsonis excluded by!**/package-lock.jsonyarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (6)
.github/workflows/build.yml.github/workflows/tauri-nightly.yml.github/workflows/test.yml.gitignoreREADME.mdpackage.json
💤 Files with no reviewable changes (1)
- .gitignore
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/build.yml (1)
56-65: Usecache: npmonactions/setup-nodeinstead of manualnode_modulescaching for consistency.The other workflows (test.yml, tauri-release.yml, tauri-nightly.yml) already use
cache: npmonactions/setup-node. Sincenpm cirecreatesnode_modulesfrom scratch anyway, align this workflow with the rest of the codebase.♻️ Suggested workflow change
- - name: Cache node_modules - uses: actions/cache@v4 - with: - path: node_modules/ - key: node_modules-${{ runner.os }}-${{ hashFiles('package-lock.json') }} - - name: Install node.js uses: actions/setup-node@v5 with: node-version-file: '.nvmrc' + cache: npm🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.github/workflows/build.yml around lines 56 - 65, Replace the manual cache step named "Cache node_modules" with using the built-in npm cache support on the setup step: remove the actions/cache step that keys node_modules-${{ runner.os }}-${{ hashFiles('package-lock.json') }} and instead add cache: npm to the actions/setup-node@v5 step (the step named "Install node.js") so the setup-node action manages npm caching consistently with other workflows.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.github/workflows/build.yml:
- Around line 56-65: Replace the manual cache step named "Cache node_modules"
with using the built-in npm cache support on the setup step: remove the
actions/cache step that keys node_modules-${{ runner.os }}-${{
hashFiles('package-lock.json') }} and instead add cache: npm to the
actions/setup-node@v5 step (the step named "Install node.js") so the setup-node
action manages npm caching consistently with other workflows.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 69f22648-de28-4204-8ce9-2a58472772ab
⛔ Files ignored due to path filters (2)
package-lock.jsonis excluded by!**/package-lock.jsonyarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (6)
.github/workflows/build.yml.github/workflows/tauri-nightly.yml.github/workflows/test.yml.gitignoreREADME.mdpackage.json
💤 Files with no reviewable changes (1)
- .gitignore
✅ Files skipped from review due to trivial changes (1)
- .github/workflows/test.yml
🚧 Files skipped from review as they are similar to previous changes (3)
- .github/workflows/tauri-nightly.yml
- package.json
- README.md
|
Contributor
|
🎉 Do you want to test this code? 🎉 |
blckmn
approved these changes
May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
Chores
Documentation