Skip to content

Cleanup: Remove dead gui_box CSS and replace native selects (#4995)#5083

Open
haslinghuis wants to merge 1 commit intobetaflight:masterfrom
haslinghuis:cleanup-4995
Open

Cleanup: Remove dead gui_box CSS and replace native selects (#4995)#5083
haslinghuis wants to merge 1 commit intobetaflight:masterfrom
haslinghuis:cleanup-4995

Conversation

@haslinghuis
Copy link
Copy Markdown
Member

@haslinghuis haslinghuis commented May 3, 2026

Summary by CodeRabbit

  • Refactor
    • Migrated form field selectors to use a unified component library across dialogs and tabs for improved consistency and better maintainability.
  • Style
    • Removed and reorganized obsolete CSS styling rules across multiple components to reduce code complexity and enhance overall cleanliness.

@haslinghuis haslinghuis added this to the 2026.6 milestone May 3, 2026
@haslinghuis haslinghuis self-assigned this May 3, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 3, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 1044aebd-e467-4636-92bd-0e73e3cd24b5

📥 Commits

Reviewing files that changed from the base of the PR and between 51cc138 and 5772ba5.

📒 Files selected for processing (3)
  • src/components/dialogs/CopyProfileDialog.vue
  • src/components/tabs/FirmwareFlasherTab.vue
  • src/components/tabs/PidTuningTab.vue
💤 Files with no reviewable changes (2)
  • src/components/tabs/PidTuningTab.vue
  • src/components/tabs/FirmwareFlasherTab.vue

Walkthrough

This PR migrates a dialog's profile and rate selectors from native HTML <select> elements to the USelect component, and removes now-orphaned CSS rules related to select and titlebar styling across multiple tab components.

Changes

UI Component & Styling Cleanup

Layer / File(s) Summary
Component Migration
src/components/dialogs/CopyProfileDialog.vue
Profile and rate <select> elements replaced with USelect components bound via :items and v-model; removes v-model.number and <option v-for> rendering.
Select-Specific CSS Removal
src/components/dialogs/CopyProfileDialog.vue
Scoped styling for .contentProfile select and .contentRateProfile select margins removed; remaining .contentProfile and .contentRateProfile container styles preserved.
Titlebar & Box Styling Cleanup
src/components/tabs/FirmwareFlasherTab.vue, src/components/tabs/PidTuningTab.vue
Orphaned .gui_box_titlebar rule block and related .gui_box / .gui_box_titlebar .helpicon margins removed; .select-group .helpicon properties consolidated.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

Suggested reviewers

  • blckmn
  • VitroidFPV
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description only contains a reference link without substantive explanation of the changes, objectives, or implementation details required by the template. Provide a detailed description explaining what changes were made, why they were made, and any relevant context. Include sections covering the motivation, implementation approach, and testing performed.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main changes: removing dead gui_box CSS and replacing native select elements with USelect components.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@haslinghuis haslinghuis moved this to App in 2026.6.0 May 3, 2026
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 3, 2026

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 3, 2026

🎉 Do you want to test this code? 🎉

⚠️ CAUTION: The build may be unstable and result in corrupted configurations or data loss. Use only for testing! ⚠️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: App

Development

Successfully merging this pull request may close these issues.

1 participant