Skip to content

Cleanup: Remove dead gui_box CSS and replace native selects (#4995) #5083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
blckmn merged 1 commit into from
May 4, 2026
+2 −39
Merged

Cleanup: Remove dead gui_box CSS and replace native selects (#4995) #5083

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 2 additions & 13 deletions src/components/dialogs/CopyProfileDialog.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,20 +7,14 @@
<div v-if="profileOptions && profileOptions.length" class="contentProfile">
<div>
<span>{{ profileText }}</span>
<select v-model.number="selectedProfile">
<option v-for="opt in profileOptions" :key="opt.value" :value="opt.value">
{{ opt.label }}
</option>
</select>
<USelect v-model="selectedProfile" :items="profileOptions" class="min-w-40" />
</div>
</div>

<div v-if="rateOptions && rateOptions.length" class="contentRateProfile">
<div>
<span>{{ rateProfileText }}</span>
<select v-model.number="selectedRateProfile">
<option v-for="opt in rateOptions" :key="opt.value" :value="opt.value">{{ opt.label }}</option>
</select>
<USelect v-model="selectedRateProfile" :items="rateOptions" class="min-w-40" />
</div>
</div>
</div>
Expand Down Expand Up @@ -98,11 +92,6 @@ defineExpose({
margin-top: 20px;
}

.contentProfile select,
.contentRateProfile select {
margin-left: 8px;
}

.dialogCopyProfile-confirmbtn {
margin: 0;
margin-right: 12px;
Expand Down
7 changes: 0 additions & 7 deletions src/components/tabs/FirmwareFlasherTab.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2588,13 +2588,6 @@ export default defineComponent({
margin-top: 0; /* keep vertically centered */
}
.build_configuration {
.gui_box_titlebar {
display: flex;
flex-direction: row-reverse;
gap: 1rem;
flex-wrap: nowrap;
align-items: center;
}
.build_configuration_toggle_wrapper {
display: flex;
flex-wrap: nowrap;
Expand Down
19 changes: 0 additions & 19 deletions src/components/tabs/PidTuningTab.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -681,27 +681,12 @@ onUnmounted(() => {
border-radius: 3px;
}

/* ── gui_box ──────────────────────────────────────────────────────── */
.tab-pid_tuning .gui_box {
padding: 0;
overflow: hidden;
gap: 0;
}
.tab-pid_tuning .gui_box span {
font-style: normal;
font-weight: normal;
line-height: 19px;
font-size: 11px;
}
.tab-pid_tuning .note,
.tab-pid_tuning .danger {
margin-bottom: 0;
}

/* ── Filter sub-tab ───────────────────────────────────────────────── */
.tab-pid_tuning .subtab-filter .gui_box {
float: none;
}
.tab-pid_tuning .subtab-filter table select {
display: inline-block;
}
Expand Down Expand Up @@ -888,10 +873,6 @@ onUnmounted(() => {
border-radius: 3px;
font-weight: normal;
}
.tab-pid_tuning .gui_box_titlebar .helpicon {
margin-top: 5px;
margin-right: 5px;
}
.tab-pid_tuning .spacer_left {
padding-left: 0;
float: right;
Expand Down
Loading