await next in hono error handler middleware#2735
Open
gingerbenw wants to merge 25 commits intonextfrom
Open
Conversation
|
| Minified | Minfied + Gzipped | |
|---|---|---|
| Before | 51.76 kB |
15.30 kB |
| After | 51.76 kB |
15.30 kB |
| ± | No change | No change |
code coverage diff
| Ok | File | Lines | Branches | Functions | Statements |
|---|---|---|---|---|---|
| 🔴 | /home/runner/work/bugsnag-js/bugsnag-js/packages/plugin-hono/src/hono.js | 90% (-4.11%) |
75% (-15%) |
100% (+0%) |
85.71% (-8.57%) |
Total:
| Lines | Branches | Functions | Statements |
|---|---|---|---|
| 84.93%(-0.02%) | 77.1%(-0.06%) | 85.17%(+0%) | 84.17%(-0.06%) |
gingerbenw
force-pushed
the
gingerbenw/hono-async-await
branch
from
b606807 to
521b9db
Compare
gingerbenw
force-pushed
the
gingerbenw/hono-async-await
branch
from
a175c8d to
2c37bcd
Compare
gingerbenw
commented
Apr 24, 2026
| And the event "session.events.unhandled" equals 1 | ||
|
|
||
| @hono-app | ||
| Scenario Outline: unhandled exceptions are reported when using hono |
Member
Author
There was a problem hiding this comment.
These have no Examples to step through, so should use Scenario rather than Scenario Outline
gingerbenw
commented
Apr 24, 2026
| And the event "session.events.unhandled" equals 1 | ||
|
|
||
| @hono-app | ||
| Scenario: thrown non-error exceptions are reported when using hono |
Member
Author
There was a problem hiding this comment.
Moved to unhandled.feature as this should have nothing to do with promise rejections
gingerbenw
commented
Apr 24, 2026
|
|
||
| app.get('/handled', async (c, next) => { | ||
| Bugsnag.notify(new Error('handled')); | ||
| c.bugsnag.notify(new Error('handled')); |
Member
Author
There was a problem hiding this comment.
use the request scoped version of bugsnag
gingerbenw
commented
Apr 24, 2026
Comment on lines
+42
to
+48
| - name: Upload test artifacts | ||
| if: failure() | ||
| uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4.6.0 | ||
| with: | ||
| name: aws-lambda-test-results | ||
| path: test/aws-lambda/maze_output/ | ||
| if-no-files-found: ignore |
Member
Author
There was a problem hiding this comment.
only upload artifacts when the tests fail so we can view the actual payloads
gingerbenw
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Updates the Hono plugin’s error-handling middleware to properly await next() and adds/adjusts integration tests and fixtures to cover async behavior, non-Error throws, and request-body parsing.
Changeset
@bugsnag/plugin-honoerror handler to await next() and handle thrown non-Error values.Testing