Open
Conversation
mcollina
requested changes
May 4, 2026
| license-check: true | ||
| lint: true | ||
| node-versions: '["16", "18", "20", "22", "24"]' | ||
| node-versions: '["20", "22", "24"]' |
Member
There was a problem hiding this comment.
no, refactor this to make it work across releases (its ok to not run ts tests on older lines)
Member
Author
There was a problem hiding this comment.
no, refactor this to make it work across releases (its ok to not run ts tests on older lines)
Yes, I deleted those versions because they were too old, It gave me this error, see here: https://github.com/fastify/fast-uri/actions/runs/25320814456/job/74229279582#step:5:836
or screenshot:
| @@ -1,24 +0,0 @@ | |||
| name: package-manager-ci | |||
Member
Author
There was a problem hiding this comment.
why?
It blocks the CI (see here: https://github.com/fastify/fast-uri/actions/runs/25320708237/job/74228738640#step:5:9); almost no Fastify library has this file.
Maybe we should start remove out Node v20 ?
mrazauskas
reviewed
May 5, 2026
Co-authored-by: Tom Mrazauskas <tom@mrazauskas.de> Signed-off-by: Antonio Tripodi <Tony133@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal:
tsdtotstychepackage-manager-ci.yml, so that CI workflows are aligned just as they are in other repositories"test-regression-check-node10"in theci.ymlfilePR of Reference: