Skip to content

refactor(types): migrate from tsd to tstyche #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tony133 wants to merge 5 commits into
base: main
Choose a base branch
from
+27 −52
Open

refactor(types): migrate from tsd to tstyche #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
70979e8
refactor(types): migrate from tsd to tstyche
Tony133 May 4, 2026
036cdf2
ci: remove package-manager-ci.yml
Tony133 May 4, 2026
ccdb0e2
ci: remove node 16 and node 18
Tony133 May 4, 2026
ff88542
chore: update index.tst.ts
Tony133 May 5, 2026
d6eed24
chore: update
Tony133 May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,4 +103,4 @@ jobs:
with:
license-check: true
lint: true
node-versions: '["16", "18", "20", "22", "24"]'
node-versions: '["20", "22", "24"]'
Copy link
Copy Markdown
Member

@mcollina mcollina May 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, refactor this to make it work across releases (its ok to not run ts tests on older lines)

Copy link
Copy Markdown
Member Author

@Tony133 Tony133 May 4, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, refactor this to make it work across releases (its ok to not run ts tests on older lines)

Yes, I deleted those versions because they were too old, It gave me this error, see here: https://github.com/fastify/fast-uri/actions/runs/25320814456/job/74229279582#step:5:836

or screenshot:

screenshot-error

24 changes: 0 additions & 24 deletions .github/workflows/package-manager-ci.yml
View file
Open in desktop

This file was deleted.

6 changes: 3 additions & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,14 +55,14 @@
"test:browser": "npm run test:browser:chromium && npm run test:browser:firefox && npm run test:browser:webkit",
"test:unit": "tape test/**/*.js",
"test:unit:dev": "npm run test:unit -- --coverage-report=html",
"test:typescript": "tsd"
"test:typescript": "tstyche"
},
"devDependencies": {
"ajv": "^8.16.0",
"eslint": "^9.17.0",
"neostandard": "^0.13.0",
"playwright-test": "^14.1.12",
"tape": "^5.8.1",
"tsd": "^0.33.0"
"tstyche": "^7.0.0"
}
}
}
15 changes: 8 additions & 7 deletions tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
{
"compilerOptions": {
"allowJs": true,
"checkJs": true,
"strict": true,
"noImplicitAny": true,
"target": "es2015"
}
"compilerOptions": {
"allowJs": true,
"checkJs": true,
"strict": true,
"noImplicitAny": true,
"target": "es2022",
"noEmit": true
}
}
17 changes: 0 additions & 17 deletions types/index.test-d.ts
View file
Open in desktop

This file was deleted.

15 changes: 15 additions & 0 deletions types/index.tst.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
import uri, {
type URIComponent,
} from '..'
import { expect } from 'tstyche'

const parsed = uri.parse('foo')
expect(parsed).type.toBe<URIComponent>()

const parsed2 = uri.parse('foo', {
domainHost: true,
scheme: 'https',
unicodeSupport: false
})

expect(parsed2).type.toBe<URIComponent>()
Loading