IBX-11848: Fixed filtering by content types in ibexa:reindex command

phpstan-baseline-lte-8.3.neon

@@ -1,11 +1,5 @@
 parameters:
 	ignoreErrors:
-		-
-			message: '#^Call to new Ibexa\\Core\\Repository\\URLAliasService\(\) on a separate line has no effect\.$#'
-			identifier: new.resultUnused
-			count: 1
-			path: tests/lib/Repository/Service/Mock/UrlAliasTest.php
-
 		-
 			message: '#^Dead catch \- Ibexa\\Contracts\\Core\\Repository\\Exceptions\\NotFoundException is never thrown in the try block\.$#'
 			identifier: catch.neverThrown

phpstan-baseline.neon

@@ -31239,7 +31239,7 @@ parameters:
 		-
 			message: '#^Offset ''scheme'' might not exist on array\{scheme\?\: string, host\: string, port\: int\<0, 65535\>, user\?\: string, pass\?\: string, path\?\: string, query\?\: string, fragment\?\: string\}\.$#'
 			identifier: offsetAccess.notFound
-			count: 4
+			count: 2
 			path: tests/bundle/Core/Routing/DefaultRouterTest.php
 
 		-

src/bundle/Core/Command/Indexer/ContentIdList/ContentTypeInputGeneratorStrategy.php

@@ -11,6 +11,7 @@
 use Generator;
 use Ibexa\Bundle\Core\Command\Indexer\ContentIdListGeneratorStrategyInterface;
 use Ibexa\Contracts\Core\Repository\ContentService;
+use Ibexa\Contracts\Core\Repository\Repository;
 use Ibexa\Contracts\Core\Repository\Values\Content\ContentList;
 use Ibexa\Contracts\Core\Repository\Values\Content\Query;
 use Ibexa\Contracts\Core\Repository\Values\Filter\Filter;
@@ -24,9 +25,12 @@
 {
     private ContentService $contentService;
 
-    public function __construct(ContentService $contentService)
+    private Repository $repository;
+
+    public function __construct(ContentService $contentService, Repository $repository)
     {
         $this->contentService = $contentService;
+        $this->repository = $repository;
     }
 
     /**
@@ -74,6 +78,11 @@
             )
         ;
 
-        return $this->contentService->find($filter);
+        /** @var \Ibexa\Contracts\Core\Repository\Values\Content\ContentList $contentList */
+        $contentList = $this->repository->sudo(function () use ($filter) {
+            return $this->contentService->find($filter);
+        });
+
+        return $contentList;
     }
 }

tests/bundle/Core/Command/Indexer/ContentIdList/ContentTypeInputGeneratorStrategyTest.php

@@ -10,6 +10,7 @@
 
 use Ibexa\Bundle\Core\Command\Indexer\ContentIdList\ContentTypeInputGeneratorStrategy;
 use Ibexa\Contracts\Core\Repository\ContentService;
+use Ibexa\Contracts\Core\Repository\Repository;
 use Ibexa\Contracts\Core\Repository\Values\Content\ContentInfo;
 use Ibexa\Contracts\Core\Repository\Values\Content\ContentList;
 use Ibexa\Contracts\Core\Repository\Values\Content\VersionInfo;
@@ -32,10 +33,20 @@ public function testGetGenerator(ContentList $contentList, int $batchSize, array
         $contentServiceMock = $this->createMock(ContentService::class);
         $contentServiceMock->method('find')->willReturn($contentList);
 
+        $repositoryMock = $this->createMock(Repository::class);
+        $repositoryMock
+            ->method('sudo')
+            ->willReturnCallback(
+                static fn (callable $callback) => $callback()
+            );
+
         $inputMock = $this->createMock(InputInterface::class);
         $inputMock->method('getOption')->with('content-type')->willReturn(uniqid('type', true));
 
-        $strategy = new ContentTypeInputGeneratorStrategy($contentServiceMock);
+        $strategy = new ContentTypeInputGeneratorStrategy(
+            $contentServiceMock,
+            $repositoryMock
+        );
 
         self::assertSame(
             $expectedBatches,

tests/integration/Core/Repository/FieldType/DateAndTimeIntegrationTest.php

@@ -35,8 +35,6 @@ public function getTypeName()
      */
     protected function supportsLikeWildcard($value)
     {
-        parent::supportsLikeWildcard($value);
-
         return false;
     }
 

tests/integration/Core/Repository/FieldType/DateIntegrationTest.php

@@ -36,8 +36,6 @@ public function getTypeName()
      */
     protected function supportsLikeWildcard($value)
     {
-        parent::supportsLikeWildcard($value);
-
         return false;
     }
 

tests/integration/Core/Repository/FieldType/RelationIntegrationTest.php

@@ -38,8 +38,6 @@ public function getTypeName()
      */
     protected function supportsLikeWildcard($value)
     {
-        parent::supportsLikeWildcard($value);
-
         return false;
     }
 

tests/integration/Core/Repository/FieldType/RelationListIntegrationTest.php

@@ -38,8 +38,6 @@ public function getTypeName()
      */
     protected function supportsLikeWildcard($value)
     {
-        parent::supportsLikeWildcard($value);
-
         return false;
     }
 

tests/integration/Core/Repository/FieldType/SelectionIntegrationTest.php

@@ -36,8 +36,6 @@ public function getTypeName()
      */
     protected function supportsLikeWildcard($value)
     {
-        parent::supportsLikeWildcard($value);
-
         return false;
     }
 

tests/integration/Core/Repository/FieldType/TimeIntegrationTest.php

@@ -34,8 +34,6 @@ public function getTypeName()
      */
     protected function supportsLikeWildcard($value)
     {
-        parent::supportsLikeWildcard($value);
-
         return false;
     }
 

tests/lib/MVC/Symfony/Component/Serializer/HostElementNormalizerTest.php

@@ -25,6 +25,7 @@ public function testNormalization(): void
         $matcher = new HostElement(2);
         // Set request and invoke match to initialize HostElement::$hostElements
         $matcher->setRequest(SimplifiedRequest::fromUrl('http://ibexa.dev/foo/bar'));
+        // @phpstan-ignore method.resultUnused
         $matcher->match();
 
         $this->assertEquals(

tests/lib/Repository/Service/Mock/ContentTest.php

@@ -89,6 +89,7 @@ public function testConstructor(): void
             'remove_archived_versions_on_publish' => true,
         ];
 
+        // @phpstan-ignore new.resultUnused
         new ContentService(
             $repositoryMock,
             $persistenceHandlerMock,

tests/lib/Repository/Service/Mock/UrlAliasTest.php

@@ -54,6 +54,7 @@ public function testConstructor()
     {
         $repositoryMock = $this->getRepositoryMock();
 
+        // @phpstan-ignore new.resultUnused
         new UrlALiasService(
             $repositoryMock,
             $this->urlAliasHandler,