IBX-11848: Fixed filtering by content types in ibexa:reindex command#760
Open
vidarl wants to merge 6 commits into
Open
Conversation
…able for anonymous
alongosz
requested changes
Jun 18, 2026
alongosz
left a comment
alongosz
left a comment
Member
There was a problem hiding this comment.
@vidarl looks like CI failure is relevant to the changes, at least when it comes to Solr integration tests.
…t available for anonymous
vidarl
force-pushed
the
IBX-11848_reindex_by_content-type_will_only_index_content_available_for_anonymous
branch
from
34ed618 to
ab30bb7
Compare
vidarl
commented
Jun 19, 2026
| */ | ||
| protected function supportsLikeWildcard($value) | ||
| { | ||
| parent::supportsLikeWildcard($value); |
Contributor
Author
There was a problem hiding this comment.
In 7129d21, parent::supportsLikeWildcard() read:
protected function supportsLikeWildcard($value)
{
if ($this->getSetupFactory() instanceof LegacyElasticsearch) {
$this->markTestSkipped('Elasticsearch Search Engine does not support Field Criterion LIKE');
}
return !is_numeric($value) && !is_bool($value);
}
However, now it only returns the return. Thus it should be safe to remove the call to parent::supportsLikeWildcard()
Contributor
Author
@alongosz : Fixed that now, and also non-releated PHPStan complains |
alongosz
changed the title
ibexa:reindex command
alongosz
approved these changes
Jun 19, 2026
alongosz
requested review from
Steveb-p,
ViniTou,
barw4,
bnowak,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
barw4
approved these changes
Jun 19, 2026
konradoboza
approved these changes
Jun 22, 2026
konradoboza
left a comment
konradoboza
left a comment
Contributor
There was a problem hiding this comment.
Apart from Bartek's comment.
tbialcz
approved these changes
Jun 22, 2026
konradoboza
reviewed
Jun 23, 2026
|
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The
--content-typeparameter foribexa:reindexwill execute a filter search (ContentService::find()), and this only returns content that is available to current user ( script is running asanonymous)For QA:
Instructions on how to reproduce is provided in ticket description
Documentation: