Skip to content

[PHPStan] Fixed reported issues after PHPStan update#767

Merged
alongosz merged 6 commits into
4.6from
phpstan/fix-new-issues-4.6-6285f7666c
Jun 24, 2026
Merged

[PHPStan] Fixed reported issues after PHPStan update#767
alongosz merged 6 commits into
4.6from
phpstan/fix-new-issues-4.6-6285f7666c

Conversation

@alongosz

Copy link
Copy Markdown
Member
🎫 Issue n/a

Related PRs:

Description:

  • Fixed HostElement::match SiteAccess matcher implementation - spotted while working on the test fix
  • [Tests] Dropped a pointless call to parent::supportsLikeWildcard in children of SearchBaseIntegrationTest
  • [Tests] Improved HostElementNormalizerTest
  • [Tests] Added @phpstan-ignore new.resultUnused to ContentTest
  • [PHPStan] Removed resolved issue count from the baseline

For QA:

No QA required.

Documentation:

No documentation required.

alongosz and others added 5 commits June 24, 2026 15:56
…of `SearchBaseIntegrationTest`

* Dropped a pointless call to `parent::supportsLikeWildcard` in children of `\Ibexa\Tests\Integration\Core\Repository\FieldType\SearchBaseIntegrationTest`

Co-Authored-By: Vidar Langseid <vidarl@users.noreply.github.com>
* `$matcher->match()` performing side effects for the object instance also returns a result which can be assessed.

* Fixed non-static call to static PHPUnit `assert*` methods

* Added missing `@throws` annotation
* The purpose of the test is to check if constructor can be instantiated without errors, so this is expected behavior.

Co-Authored-By: Vidar Langseid <vidarl@users.noreply.github.com>
Co-Authored-By: Vidar Langseid <vidarl@users.noreply.github.com>
@alongosz alongosz force-pushed the phpstan/fix-new-issues-4.6-6285f7666c branch from c87d5b1 to 446c04d Compare June 24, 2026 13:58
…Test

* The purpose of the test is to check if constructor can be instantiated without errors, so this is expected behavior.

Co-Authored-By: Vidar Langseid <vidarl@users.noreply.github.com>
@alongosz alongosz merged commit 242cac2 into 4.6 Jun 24, 2026
69 of 70 checks passed
@alongosz alongosz deleted the phpstan/fix-new-issues-4.6-6285f7666c branch June 24, 2026 21:14
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants