[PHPStan] Fixed reported issues after PHPStan update

phpstan-baseline-lte-8.3.neon

@@ -1,11 +1,5 @@
 parameters:
 	ignoreErrors:
-		-
-			message: '#^Call to new Ibexa\\Core\\Repository\\URLAliasService\(\) on a separate line has no effect\.$#'
-			identifier: new.resultUnused
-			count: 1
-			path: tests/lib/Repository/Service/Mock/UrlAliasTest.php
-
 		-
 			message: '#^Dead catch \- Ibexa\\Contracts\\Core\\Repository\\Exceptions\\NotFoundException is never thrown in the try block\.$#'
 			identifier: catch.neverThrown

phpstan-baseline.neon

@@ -31239,7 +31239,7 @@ parameters:
 		-
 			message: '#^Offset ''scheme'' might not exist on array\{scheme\?\: string, host\: string, port\: int\<0, 65535\>, user\?\: string, pass\?\: string, path\?\: string, query\?\: string, fragment\?\: string\}\.$#'
 			identifier: offsetAccess.notFound
-			count: 4
+			count: 2
 			path: tests/bundle/Core/Routing/DefaultRouterTest.php
 
 		-

src/lib/MVC/Symfony/SiteAccess/Matcher/HostElement.php

@@ -57,7 +57,7 @@ public function match()
     {
         $elements = $this->getHostElements();
 
-        return isset($elements[$this->elementNumber - 1]) ? $elements[$this->elementNumber - 1] : false;
+        return $elements[$this->elementNumber - 1] ?? false;
     }
 
     public function getName()

tests/integration/Core/Repository/FieldType/DateAndTimeIntegrationTest.php

@@ -30,13 +30,8 @@ public function getTypeName()
         return 'ezdatetime';
     }
 
-    /**
-     * {@inheritdoc}
-     */
-    protected function supportsLikeWildcard($value)
+    protected function supportsLikeWildcard($value): bool
     {
-        parent::supportsLikeWildcard($value);
-
         return false;
     }
 

tests/integration/Core/Repository/FieldType/DateIntegrationTest.php

@@ -31,13 +31,8 @@ public function getTypeName()
         return 'ezdate';
     }
 
-    /**
-     * {@inheritdoc}
-     */
-    protected function supportsLikeWildcard($value)
+    protected function supportsLikeWildcard($value): bool
     {
-        parent::supportsLikeWildcard($value);
-
         return false;
     }
 

tests/integration/Core/Repository/FieldType/RelationIntegrationTest.php

@@ -33,13 +33,8 @@ public function getTypeName()
         return 'ezobjectrelation';
     }
 
-    /**
-     * {@inheritdoc}
-     */
-    protected function supportsLikeWildcard($value)
+    protected function supportsLikeWildcard($value): bool
     {
-        parent::supportsLikeWildcard($value);
-
         return false;
     }
 

tests/integration/Core/Repository/FieldType/RelationListIntegrationTest.php

@@ -33,13 +33,8 @@ public function getTypeName()
         return 'ezobjectrelationlist';
     }
 
-    /**
-     * {@inheritdoc}
-     */
-    protected function supportsLikeWildcard($value)
+    protected function supportsLikeWildcard($value): bool
     {
-        parent::supportsLikeWildcard($value);
-
         return false;
     }
 

tests/integration/Core/Repository/FieldType/SelectionIntegrationTest.php

@@ -34,10 +34,8 @@ public function getTypeName()
      *
      * If Selection is improved to be able to index + search for string also with LegacySearch, then adapt this too.
      */
-    protected function supportsLikeWildcard($value)
+    protected function supportsLikeWildcard($value): bool
     {
-        parent::supportsLikeWildcard($value);
-
         return false;
     }
 

tests/integration/Core/Repository/FieldType/TimeIntegrationTest.php

@@ -29,13 +29,8 @@ public function getTypeName()
         return 'eztime';
     }
 
-    /**
-     * {@inheritdoc}
-     */
-    protected function supportsLikeWildcard($value)
+    protected function supportsLikeWildcard($value): bool
     {
-        parent::supportsLikeWildcard($value);
-
         return false;
     }
 

tests/lib/MVC/Symfony/Component/Serializer/HostElementNormalizerTest.php

@@ -17,6 +17,9 @@
 
 final class HostElementNormalizerTest extends TestCase
 {
+    /**
+     * @throws \Symfony\Component\Serializer\Exception\ExceptionInterface
+     */
     public function testNormalization(): void
     {
         $normalizer = new HostElementNormalizer();
@@ -25,9 +28,9 @@ public function testNormalization(): void
         $matcher = new HostElement(2);
         // Set request and invoke match to initialize HostElement::$hostElements
         $matcher->setRequest(SimplifiedRequest::fromUrl('http://ibexa.dev/foo/bar'));
-        $matcher->match();
+        self::assertSame('dev', $matcher->match());
 
-        $this->assertEquals(
+        self::assertEquals(
             [
                 'elementNumber' => 2,
                 'hostElements' => [
@@ -43,8 +46,8 @@ public function testSupportsNormalization(): void
     {
         $normalizer = new HostElementNormalizer();
 
-        $this->assertTrue($normalizer->supportsNormalization($this->createMock(HostElement::class)));
-        $this->assertFalse($normalizer->supportsNormalization($this->createMock(Matcher::class)));
+        self::assertTrue($normalizer->supportsNormalization($this->createMock(HostElement::class)));
+        self::assertFalse($normalizer->supportsNormalization($this->createMock(Matcher::class)));
     }
 }
 

tests/lib/Repository/Service/Mock/ContentTest.php

@@ -89,6 +89,7 @@ public function testConstructor(): void
             'remove_archived_versions_on_publish' => true,
         ];
 
+        /** @phpstan-ignore new.resultUnused */
         new ContentService(
             $repositoryMock,
             $persistenceHandlerMock,

tests/lib/Repository/Service/Mock/UrlAliasTest.php

@@ -54,6 +54,7 @@ public function testConstructor()
     {
         $repositoryMock = $this->getRepositoryMock();
 
+        /** @phpstan-ignore new.resultUnused */
         new UrlALiasService(
             $repositoryMock,
             $this->urlAliasHandler,