Use Windows system certificate store for CLI TLS transport#1351
Merged
Conversation
Contributor
|
I have read the CLA Document and I hereby sign the CLA remib seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
Co-authored-by: Cesar-DC <21956449+Cesar-DC@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
RemiBou
force-pushed
the
bugfix/issue-3141-windows-system-cert-pool
branch
from
08bdaf3 to
ea31c9e
Compare
RemiBou
added
the
safe to test
| ) | ||
|
|
||
| func loadSystemRoots() (*x509.CertPool, error) { | ||
| pool, err := x509.SystemCertPool() |
There was a problem hiding this comment.
Would it make sense to return err early if there is one?
vitaliil-jfrog
approved these changes
Jun 3, 2026
Contributor
cyrilc-pro
approved these changes
Jun 3, 2026
…or return Co-authored-by: Cesar-DC <21956449+Cesar-DC@users.noreply.github.com> Co-authored-by: Cursor <cursoragent@cursor.com>
RemiBou
added
safe to test
RemiBou
changed the title
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
x509.SystemCertPool()returns a nil pool (notably on Windows), fall back tox509.NewCertPool()so TLS transport setup never passes a nilRootCAspool.loadSystemRootshelpers into a single implementation usingSystemCertPool.loader.goand add unit tests for cert pool loading and transport configuration.Based on Cesar-DC/jfrog-client-go@bugfix-issue-3141, discussed in jfrog/jfrog-cli#3441. Related to jfrog/jfrog-cli#2309.
Test plan
go test ./auth/cert/...Made with Cursor