Conversation
| jobs: | ||
| nvi-correctness-tests: | ||
| if: github.event_name == 'merge_group' | ||
| #if: github.event_name == 'merge_group' |
There was a problem hiding this comment.
I've disabled the option to run the CI job on merge queue only for testing purposes, happy to add it back after the CI is green.
|
Hi, @ParagEkbote . I think the problem of that CI is that we didn't have an available modal account for now. We are still working on getting an account, so we are manually testing the correctness locally on H100 environment before merging the PRs. Feel free to ping me or @vaibhavjindal after you create the PR. |
The PR could be converted to draft for now, please let me know when you get the modal account and I'll test to see if the CI works. |
Summary
Since the Nvidia CI is failing on main, this PR aims to fix this issue. I've added the missing
-mflag as needed by the modal docs. Currently, the CI jobs are failing due to the auth secret token which could be expired, could you please check the same?cc: @Tcc0403
Testing Done
make testto ensure correctnessmake checkstyleto ensure code stylemake test-convergenceto ensure convergence