Skip to content

Fix Nvidia CI#1198

Draft
ParagEkbote wants to merge 4 commits intolinkedin:mainfrom
ParagEkbote:fix-nvidia-ci
Draft

Fix Nvidia CI#1198
ParagEkbote wants to merge 4 commits intolinkedin:mainfrom
ParagEkbote:fix-nvidia-ci

Conversation

@ParagEkbote
Copy link
Copy Markdown
Contributor

@ParagEkbote ParagEkbote commented Apr 22, 2026

Summary

Since the Nvidia CI is failing on main, this PR aims to fix this issue. I've added the missing -m flag as needed by the modal docs. Currently, the CI jobs are failing due to the auth secret token which could be expired, could you please check the same?

cc: @Tcc0403

Testing Done

  • Hardware Type:
  • run make test to ensure correctness
  • run make checkstyle to ensure code style
  • run make test-convergence to ensure convergence

jobs:
nvi-correctness-tests:
if: github.event_name == 'merge_group'
#if: github.event_name == 'merge_group'
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've disabled the option to run the CI job on merge queue only for testing purposes, happy to add it back after the CI is green.

@Mecoli1219
Copy link
Copy Markdown
Collaborator

Hi, @ParagEkbote . I think the problem of that CI is that we didn't have an available modal account for now. We are still working on getting an account, so we are manually testing the correctness locally on H100 environment before merging the PRs. Feel free to ping me or @vaibhavjindal after you create the PR.

@ParagEkbote
Copy link
Copy Markdown
Contributor Author

Hi, @ParagEkbote . I think the problem of that CI is that we didn't have an available modal account for now. We are still working on getting an account, so we are manually testing the correctness locally on H100 environment before merging the PRs. Feel free to ping me or @vaibhavjindal after you create the PR.

The PR could be converted to draft for now, please let me know when you get the modal account and I'll test to see if the CI works.

@ParagEkbote ParagEkbote marked this pull request as draft April 22, 2026 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants