Skip to content

Fix Nvidia CI #1198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ParagEkbote wants to merge 4 commits into
base: main
Choose a base branch
from
+5 −5
Draft

Fix Nvidia CI #1198

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0776dcd
attempt to fix the nvidia ci with missing modal flag.
ParagEkbote Apr 22, 2026
ed2d27b
modify to test.
ParagEkbote Apr 22, 2026
afd826f
let's add auth for modal.
ParagEkbote Apr 22, 2026
1267d8e
rm auth for now.
ParagEkbote Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/nvi-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ concurrency:

jobs:
nvi-correctness-tests:
if: github.event_name == 'merge_group'
#if: github.event_name == 'merge_group'
Copy link
Copy Markdown
Contributor Author

@ParagEkbote ParagEkbote Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've disabled the option to run the CI job on merge queue only for testing purposes, happy to add it back after the CI is green.

runs-on: ubuntu-latest
env:
MODAL_TOKEN_ID: ${{ secrets.MODAL_TOKEN_ID }}
Expand All @@ -41,7 +41,7 @@ jobs:

- name: Run tests
run: |
modal run dev.modal.tests::liger_correctness_tests
modal run -m dev.modal.tests::liger_correctness_tests

nvi-convergence-tests:
if: github.event_name == 'merge_group'
Expand All @@ -66,7 +66,7 @@ jobs:

- name: Run tests
run: |
modal run dev.modal.tests::liger_convergence_tests
modal run -m dev.modal.tests::liger_convergence_tests

nvi-correctness-tests-with-transformers-4-52-0:
if: github.event_name == 'merge_group'
Expand All @@ -91,7 +91,7 @@ jobs:

- name: Run tests
run: |
modal run dev.modal.tests::liger_oldest_v4_correctness_tests
modal run -m dev.modal.tests::liger_oldest_v4_correctness_tests


nvi-convergence-tests-with-transformers-4-52-0:
Expand All @@ -117,4 +117,4 @@ jobs:

- name: Run tests
run: |
modal run dev.modal.tests::liger_oldest_v4_convergence_tests
modal run -m dev.modal.tests::liger_oldest_v4_convergence_tests
Loading