Draft: Autogenerate mocks#377
Draft
lorenzodonini wants to merge 4 commits intomasterfrom
Draft
Conversation
Signed-off-by: Lorenzo <lorenzo.donini90@gmail.com>
Signed-off-by: Lorenzo <lorenzo.donini90@gmail.com>
Signed-off-by: Lorenzo <lorenzo.donini90@gmail.com>
lorenzodonini
force-pushed
the
mocks-autogen
branch
from
febd13b to
9504562
Compare
xBlaz3kx
reviewed
Aug 16, 2025
| uses: jaxxstorm/action-install-gh-release@v1.10.0 | ||
| with: # Grab a specific tag | ||
| repo: vektra/mockery | ||
| tag: v2.53.3 |
Contributor
There was a problem hiding this comment.
Should probably bump to v3
lorenzodonini
force-pushed
the
mocks-autogen
branch
2 times, most recently
from
28a619b to
6792698
Compare
Signed-off-by: Lorenzo <lorenzo.donini90@gmail.com>
lorenzodonini
force-pushed
the
mocks-autogen
branch
from
6792698 to
d188833
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Generated mock files are not committed to VCS anymore and are ignored by git instead. This prevents from running a CI job for committing updated mocks to the repo after each pull request.
To run unit tests, the mocks still need to be generated. This can be done either:
mockeryormake mockscommandMocks are auto-generated in the CI before running unit tests.
Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that applyFurther comments
Possibly a controversial change, but I believe having auto-generated files checked in is more of a burden. For local development the mocks will ideally be generated once and forgotten. The CI has to generate them each time but the step takes ~15s, so not a big deal.