test cases: skip test_python_build_config_extensions with pkg-config installed#15797
Closed
mtelka wants to merge 1 commit intomesonbuild:masterfrom
Closed
test cases: skip test_python_build_config_extensions with pkg-config installed#15797mtelka wants to merge 1 commit intomesonbuild:masterfrom
mtelka wants to merge 1 commit intomesonbuild:masterfrom
Conversation
eli-schwartz
requested changes
May 10, 2026
| with self.subTest(build_config_via_cross=build_config_via_cross, sys_root=sys_root): | ||
| # fd.o pkg-config does not handle sys_root correctly | ||
| if sys_root is not None and with_pkgconfig and shutil.which('pkgconf') is None: | ||
| if sys_root is not None and with_pkgconfig and shutil.which('pkg-config') is not None: |
Member
There was a problem hiding this comment.
This change is certainly as wrong as it is possible to be.
Why are you choosing to skip the test on all systems (because on systems where only pkgconf is installed, pkg-config is a compatibility symlink for pkgconf)?
Contributor
Author
There was a problem hiding this comment.
Fair question. Unfortunately, I do not have any system with pkgconf-only installed, so I'm not aware about existence of the pkg-config compatibility symlink. If that's the case then this change is obviously wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #15796