Skip to content

test cases: skip test_python_build_config_extensions with pkg-config installed #15797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mtelka wants to merge 1 commit into from
+1 −1
Closed

test cases: skip test_python_build_config_extensions with pkg-config installed #15797

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion unittests/allplatformstests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3184,7 +3184,7 @@ def test_python_build_config_extensions(self):
for sys_root in (None, sys.base_prefix):
with self.subTest(build_config_via_cross=build_config_via_cross, sys_root=sys_root):
# fd.o pkg-config does not handle sys_root correctly
if sys_root is not None and with_pkgconfig and shutil.which('pkgconf') is None:
if sys_root is not None and with_pkgconfig and shutil.which('pkg-config') is not None:
Copy link
Copy Markdown
Member

@eli-schwartz eli-schwartz May 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is certainly as wrong as it is possible to be.

Why are you choosing to skip the test on all systems (because on systems where only pkgconf is installed, pkg-config is a compatibility symlink for pkgconf)?

Copy link
Copy Markdown
Contributor Author

@mtelka mtelka May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair question. Unfortunately, I do not have any system with pkgconf-only installed, so I'm not aware about existence of the pkg-config compatibility symlink. If that's the case then this change is obviously wrong.

raise SkipTest('sys_root subtest skipped because of fd.o pkg-config')

with tempfile.NamedTemporaryFile(mode='w', delete=False, encoding='utf-8') as cross_file:
Expand Down
Loading