Fix TRX result attachment layout to include per-test relative results directory

[Copilot]

Bug Fix

What was the bug?

With --report-trx --results-directory TestResults, per-test artifacts were copied to .../In/<machine>/... while TRX consumers resolved attachments via .../In/<relativeResultsDirectory>/<machine>/.... This mismatch caused attachment open failures locally and dropped attachments in Azure DevOps publishing.

How did you fix it?

• Align per-test artifact copy path with TRX resolution semantics
  • Updated TrxReportEngine to route per-test artifact copies under:
    • <resultsDirectory>/<runDeploymentRoot>/In/<executionId>/<machineName>/...
  • executionId is already emitted as relativeResultsDirectory, so physical layout now matches downstream lookup behavior.
• Keep existing href behavior unchanged
  • ResultFile path remains machine-relative (<machineName>/<fileName>), preserving current TRX payload shape.
• Add focused regression coverage
  • Extended the existing TRX unit test to assert copy destination includes the relativeResultsDirectory segment.

string directoryName = relativeResultsDirectory is null
    ? Path.Combine(_configuration.GetTestResultDirectory(), runDeploymentRoot, "In", _environment.MachineName)
    : Path.Combine(_configuration.GetTestResultDirectory(), runDeploymentRoot, "In", relativeResultsDirectory, _environment.MachineName);

// per-test artifacts now pass executionId as relativeResultsDirectory
string href = CopyArtifactIntoTrxDirectoryAndReturnHrefValue(testFileArtifact.FileInfo, runDeploymentRoot, executionId);

Testing

Added/updated unit coverage in TrxTests to verify that per-test artifact copy paths include:
.../In/<relativeResultsDirectory>/MachineName/fileName.

[Evangelink]

@copilot please add an acceptance test too

[Copilot]

Pull request overview

This PR fixes a TRX attachment layout mismatch where per-test artifacts were being copied to .../In/<machine>/... while TRX consumers resolve them via .../In/<relativeResultsDirectory>/<machine>/..., causing attachment resolution failures (including Azure DevOps publishing).

Changes:

• Updated TrxReportEngine to copy per-test ResultFile artifacts under runDeploymentRoot/In/<relativeResultsDirectory>/<machine>/... by passing executionId (emitted as relativeResultsDirectory) into the copy-path computation.
• Kept TRX ResultFile path values machine-relative (<machine>/<file>), preserving existing TRX payload shape.
• Extended the existing TRX unit test to assert that the copy destination includes the relativeResultsDirectory segment.

Show a summary per file

File	Description
src/Platform/Microsoft.Testing.Extensions.TrxReport/TrxReportEngine.cs	Routes per-test artifact copy destinations under In/<relativeResultsDirectory>/<machine> while keeping href machine-relative.
test/UnitTests/Microsoft.Testing.Extensions.UnitTests/TrxTests.cs	Adds regression assertion verifying the per-test artifact copy destination includes relativeResultsDirectory.

Copilot's findings

• Files reviewed: 2/2 changed files
• Comments generated: 0

[Copilot]

@copilot please add an acceptance test too

Added an acceptance test in TrxTests to cover this scenario (commit 719c704). It validates that with --report-trx + --results-directory, per-test artifacts are copied under In/<relativeResultsDirectory>/<machine>/... and not the legacy path.

[Evangelink]

/review

[github-actions]

❌ Expert Code Review (command) failed. Please review the logs for details.