Fix: allow function calls in op is expressions#10860
Draft
Copilot wants to merge 2 commits into
Draft
Conversation
Previously, writing `op test is myFunction(args)` would produce a "A value cannot be used as a type" error, requiring an intermediate alias as a workaround. Changes: - Parser: use parseCallOrReferenceExpression() for op is - AST: baseOperation accepts TypeReferenceNode | CallExpressionNode - Name resolver: guard against CallExpressionNode - Checker: handle CallExpressionNode in checkOperationIs Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issue with functions in op is causing type error
Fix: allow function calls in Jun 2, 2026
op is expressions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Function calls returning
Operationcould not be used directly inop is— the compiler reported "A value cannot be used as a type." An intermediate alias was required as a workaround.Changes
op isnow usesparseCallOrReferenceExpression()instead ofparseReferenceExpression(), accepting both type references and function callstypes.ts):OperationSignatureReferenceNode.baseOperationwidened toTypeReferenceNode | CallExpressionNodeCallExpressionNode(results are dynamic)checkOperationIsconditionally performs circular-reference checks only forTypeReferenceNode;CallExpressionNodeflows throughgetTypeForNode→checkCallExpressionas normal