Update to Blockly 12#3768
Open
mjgallag wants to merge 18 commits into
Open
Conversation
17 tasks
17 tasks
Contributor
Author
|
@ewpatton this is rebased per our discussion earlier today, see 1353040. mit-cml/blockly#13 has been rebased too, now it is just a straight upgrade to 12 no new changes added to our fork. |
RaspberryPiFoundation/blockly@59fab94 https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/css.ts#L217-L219 https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/renderers/common/constants.ts#L254 https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/renderers/common/constants.ts#L1166-L1171 https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/renderers/common/constants.ts#L1172-L1175 https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/renderers/common/constants.ts#L1187-L1191
https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/css.ts#L148-L152 https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/css.ts#L160-L162 https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/css.ts#L189-L193 https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/css.ts#L195-L197 https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/css.ts#L205-L208 https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/css.ts#L234-L239 https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/css.ts#L301-L304 https://github.com/RaspberryPiFoundation/blockly/blob/blockly-v12.5.1/packages/blockly/core/css.ts#L345-L347
Contributor
Author
|
@ewpatton see bd2f855 which fixes 4fadad8 the correct but more risky way. I included both so if we need to revert to simple workaround we can. This has been deployed to https://arched-branch-471517-f9.uc.r.appspot.com. |
Stage the BlocklyPanel element in a hidden div before initializing the workspace. GWT later moves it into the ProjectEditor deck when the editor is added. Blockly measures a hidden workspace using computed CSS, which requires the workspace element to be attached to the document. RaspberryPiFoundation/blockly#8572
Removes staging of BlocklyPanel element in a hidden div before initializing the workspace workaround.
Contributor
Author
|
I just pushed Fix D duplicate multiselect shortcut, which was new and thus needed to be implemented for multiselect. There are some small older bugs being found in multiselect that I will get addressed after blockly summit when I return but I don't think any of them are blocking in terms of this moving into testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General items:
ant testspasses on my machineIf your code changes how something works on the device (i.e., it affects the companion):
ucrucras the baseFurther, if you've changed the blocks language or another user-facing designer/blocks API (added a SimpleProperty, etc.):
For all other changes:
mastermasteras the baseWhat does this PR accomplish?
mit-cml/blockly#13
josmas/blockly-plugins#5
mit-cml/blockly-plugins#68
mit-cml/workspace-multiselect#133
https://arched-branch-471517-f9.uc.r.appspot.com
I had to map all of the single letter shortcuts due to typeblocking. I went with option/alt as it seemed to lack system conflicts.
New App Inventor Mapping:
Default Blockly Mapping:
Resolves #3759.