fix(operator): add helm.sh/resource-policy: keep when recreate is false#2172
Open
tmohanvamsi wants to merge 1 commit intoopen-telemetry:mainfrom
Open
fix(operator): add helm.sh/resource-policy: keep when recreate is false#2172tmohanvamsi wants to merge 1 commit intoopen-telemetry:mainfrom
tmohanvamsi wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
When autoGenerateCert.recreate is set to false, the webhook secret is now annotated with helm.sh/resource-policy: keep. This prevents ArgoCD from deleting and recreating the certificate on every sync, which was caused by ArgoCD's dry-run mode not supporting the Helm lookup function. Updated values.yaml documentation to explain the ArgoCD behavior. Fixes open-telemetry#2168 Signed-off-by: tadepmo <tmohanvamsi@gmail.com>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
autoGenerateCert.recreateis set tofalse, the webhook secret is now annotated withhelm.sh/resource-policy: keep. This prevents ArgoCD from deleting and recreating the certificate on every sync.Root Cause
ArgoCD uses
helm template(dry-run mode) which does not support the Helmlookupfunction. As a result, the existing secret is never found, theelsebranch always executes, and a new certificate is generated on every sync — even whenrecreate: falseis set.Fix
helm.sh/resource-policy: keepannotation to the webhook Secret whenautoGenerateCert.recreate: falsevalues.yamldocumentation to explain ArgoCD behaviorTesting
recreate: falsewill no longer see certificate diffs on every syncRelated Issue
Fixes #2168