Skip to content

fix(operator): add helm.sh/resource-policy: keep when recreate is false #2172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tmohanvamsi wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −3
Open

fix(operator): add helm.sh/resource-policy: keep when recreate is false #2172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions charts/opentelemetry-operator/templates/admission-webhooks/operator-webhook.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,13 @@ apiVersion: v1
kind: Secret
type: kubernetes.io/tls
metadata:
{{- if .Values.admissionWebhooks.secretAnnotations }}
annotations:
{{- toYaml .Values.admissionWebhooks.secretAnnotations | nindent 4 }}
{{- end }}
{{- if .Values.admissionWebhooks.secretAnnotations }}
{{- toYaml .Values.admissionWebhooks.secretAnnotations | nindent 4 }}
{{- end }}
{{- if not .Values.admissionWebhooks.autoGenerateCert.recreate }}
helm.sh/resource-policy: keep
{{- end }}
labels:
{{- include "opentelemetry-operator.labels" . | nindent 4 }}
app.kubernetes.io/component: webhook
Expand Down
2 changes: 2 additions & 0 deletions charts/opentelemetry-operator/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,6 +305,8 @@ admissionWebhooks:
autoGenerateCert:
enabled: true
# If set to true, new webhook key/certificate is generated on helm upgrade.
# If set to false, the existing certificate is reused and helm.sh/resource-policy: keep
# is added to the secret, preventing ArgoCD from recreating the certificate on every sync.
recreate: true
# Cert period time in days. The default is 365 days.
certPeriodDays: 365
Expand Down