add rcl_publisher/subscription_event_type_is_supported().#1317
add rcl_publisher/subscription_event_type_is_supported().#1317fujitatomoya wants to merge 1 commit into
Conversation
Signed-off-by: Tomoya Fujita <tomoya.fujita825@gmail.com>
There was a problem hiding this comment.
Pull request overview
Adds runtime introspection APIs in rcl to check whether specific publisher/subscription event types are supported by the active RMW implementation, and updates/extends tests accordingly (follow-up to ros2/rmw#394).
Changes:
- Introduce
rcl_publisher_event_type_is_supported()andrcl_subscription_event_type_is_supported()inrcl. - Update an existing event test to use the new
rcl_subscription_*_is_supported()API. - Add new unit tests verifying the new
rclAPIs matchrmw_event_type_is_supported()results.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
rcl/src/rcl/event.c |
Implements the two new *_event_type_is_supported() helper APIs by mapping to rmw_event_type_is_supported(). |
rcl/include/rcl/event.h |
Declares the new public APIs and documents their intent and behavior. |
rcl/test/rcl/test_events.cpp |
Updates one skip-condition to use the new API and adds coverage to compare rcl vs rmw support results. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fujitatomoya
left a comment
fujitatomoya
left a comment
There was a problem hiding this comment.
@ahcorde can you review this? (probably after lyrical luth release.)
|
@ahcorde can you see my comment #1317 (comment) and approve this? i just rebased ros2/rclpy#1647 and ros2/rclcpp#3132 too. |
|
Pulls: #1317, ros2/rclcpp#3132, ros2/rclpy#1647
|
Description
follow up of ros2/rmw#394
Fixes # (issue)
Is this user-facing behavior change?
No
Did you use Generative AI?
Yes Claude Code Opus4.6
Additional Information