add publisher/subscription_event_type_is_supported().#1647
Conversation
There was a problem hiding this comment.
Pull request overview
Adds Python-accessible helpers to query whether specific publisher/subscription QoS event types are supported by the active RMW implementation, with accompanying unit tests.
Changes:
- Expose
publisher_event_type_is_supported()/subscription_event_type_is_supported()via_rclpy(pybind11) andrclpy.event_handler. - Add unit tests covering return type for all event enum values and asserting MATCHED is supported.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rclpy/test/test_qos_event.py | Adds tests validating the new support-query helpers across event enums. |
| rclpy/src/rclpy/event_handle.cpp | Implements and binds the two new support-query functions into the pybind11 module. |
| rclpy/rclpy/event_handler.py | Adds Python wrappers (public API surface) for the new _rclpy functions. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fujitatomoya
left a comment
There was a problem hiding this comment.
@ahcorde can you review this?
Signed-off-by: Tomoya Fujita <tomoya.fujita825@gmail.com>
89ac6d2 to
257f58d
Compare
|
Pulls: ros2/rcl#1317, ros2/rclcpp#3132, #1647 |
Description
depends on ros2/rcl#1317
Fixes # (issue)
Is this user-facing behavior change?
No
Did you use Generative AI?
Yes Claude Code Opus4.6
Additional Information