Skip to content

add publisher/subscription_event_type_is_supported().#1647

Open
fujitatomoya wants to merge 1 commit into
rollingfrom
fujitatomoya/rmw/pull/395/followup
Open

add publisher/subscription_event_type_is_supported().#1647
fujitatomoya wants to merge 1 commit into
rollingfrom
fujitatomoya/rmw/pull/395/followup

Conversation

@fujitatomoya
Copy link
Copy Markdown
Collaborator

Description

depends on ros2/rcl#1317

Fixes # (issue)

Is this user-facing behavior change?

No

Did you use Generative AI?

Yes Claude Code Opus4.6

Additional Information

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Python-accessible helpers to query whether specific publisher/subscription QoS event types are supported by the active RMW implementation, with accompanying unit tests.

Changes:

  • Expose publisher_event_type_is_supported() / subscription_event_type_is_supported() via _rclpy (pybind11) and rclpy.event_handler.
  • Add unit tests covering return type for all event enum values and asserting MATCHED is supported.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
rclpy/test/test_qos_event.py Adds tests validating the new support-query helpers across event enums.
rclpy/src/rclpy/event_handle.cpp Implements and binds the two new support-query functions into the pybind11 module.
rclpy/rclpy/event_handler.py Adds Python wrappers (public API surface) for the new _rclpy functions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@fujitatomoya fujitatomoya requested a review from ahcorde April 15, 2026 22:49
Comment thread rclpy/rclpy/event_handler.py
Copy link
Copy Markdown
Collaborator Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahcorde can you review this?

Signed-off-by: Tomoya Fujita <tomoya.fujita825@gmail.com>
@fujitatomoya
Copy link
Copy Markdown
Collaborator Author

Pulls: ros2/rcl#1317, ros2/rclcpp#3132, #1647
Gist: https://gist.githubusercontent.com/fujitatomoya/da0945366990a7a90848379cce0e0673/raw/deef0ce8ee6811fcb8d377a8ecf8ddda07e6fe23/ros2.repos
BUILD args: --packages-above-and-dependencies rcl rclcpp rclpy
TEST args: --packages-above rcl rclcpp rclpy
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19228

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants