[Gear] Trinket - Font of Venomous Rage#11531
Conversation
nyterage
left a comment
nyterage
left a comment
There was a problem hiding this comment.
neither of these are really vital. but wanted to point out their existence as they can make things a bit easier.
| generic_aoe_proc_t( e, "venom_splatter", e.player->find_spell( 1307222 ) ) | ||
| {} | ||
|
|
||
| size_t available_targets( std::vector<player_t*>& tl ) const override |
There was a problem hiding this comment.
should be able to use target_filter_callback for this rather than manually adjusting available_targets.
specifically target_filter_callback = secondary_targets_only();.
There was a problem hiding this comment.
neat! i just found an earlier implementation of a way to remove main target
| player->reset_auto_attacks( composite_dot_duration( execute_state ) ); | ||
| } | ||
|
|
||
| void tick( dot_t* d ) override |
There was a problem hiding this comment.
can just set venom_splatter to be the channels tick action to achieve this as well
tick_action = venom_splatter in the channel constructor.
There was a problem hiding this comment.
doesn't this overwrite the tick dmg of the actual main target dmg of the channel?
There was a problem hiding this comment.
no, the actual main action tick damage is handled in the base_td. has nothing to do with tick_action. all tick_action setting does is automatically execute that on the target on tick, while also handling the automatic state updates, direct_tick flags, etc. all this means is tick_action should ideally be used whenever you have an action being executed on a tick.
There was a problem hiding this comment.
i'm sorry, but when i use the tick action, this is the log
Player schedules execute for Action 'use_item_font_of_venomous_rage' (0)
Player performs Action 'font_of_venemous_rage' (1297908) (216117.5)
Player Action 'font_of_venemous_rage' (1297908) hits Enemy 'Pull_1_9tar' for 0.000000 nature damage (crit)
Player schedules execute for Action 'venom_splatter' (1307222)
Player Action 'font_of_venemous_rage' (1297908) ticks (0 of 4) Enemy 'Pull_1_9tar'
Player Action 'venom_splatter' (1307222) hits Enemy 'Pull_1_9tar_copy1' for 73636.785750 nature damage (crit)
Player Action 'venom_splatter' (1307222) hits Enemy 'Pull_1_9tar_copy2' for 32571.874132 nature damage (hit)
and on subsequent ticks
Player schedules execute for Action 'venom_splatter' (1307222)
Player Action 'font_of_venemous_rage' (1297908) ticks (1 of 4) Enemy 'Pull_1_9tar'
Player Action 'venom_splatter' (1307222) hits Enemy 'Pull_1_9tar_copy1' for 32571.874132 nature damage (hit)
Player Action 'venom_splatter' (1307222) hits Enemy 'Pull_1_9tar_copy2' for 32571.874132 nature damage (hit)
instead of
Player schedules execute for Action 'use_item_font_of_venomous_rage' (0)
Player performs Action 'font_of_venemous_rage' (1297908) (215752.5)
Player Action 'font_of_venemous_rage' (1297908) hits Enemy 'Pull_1_9tar' for 0.000000 nature damage (hit)
Player Action 'font_of_venemous_rage' (1297908) ticks (0 of 4) on Enemy 'Pull_1_9tar' for 592263.906001 nature damage (hit)
Player Action 'venom_splatter' (1307222) hits Enemy 'Pull_1_9tar_copy1' for 32571.874132 nature damage (hit)
Player Action 'venom_splatter' (1307222) hits Enemy 'Pull_1_9tar_copy2' for 32571.874132 nature damage (hit)
and
Player Action 'font_of_venemous_rage' (1297908) ticks (1 of 4) on Enemy 'Pull_1_9tar' for 592263.906001 nature damage (hit)
Player Action 'venom_splatter' (1307222) hits Enemy 'Pull_1_9tar_copy1' for 32571.874132 nature damage (hit)
Player Action 'venom_splatter' (1307222) hits Enemy 'Pull_1_9tar_copy2' for 73636.785750 nature damage (crit)
2 participants
No description provided.