Skip to content

[Gear] Trinket - Font of Venomous Rage #11531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nyterage merged 4 commits into from
Jun 25, 2026
+57 −0
Merged

[Gear] Trinket - Font of Venomous Rage #11531

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8bce798
[Gear] Trinket - Font of Venomous Rage
criller7070 Jun 23, 2026
d9629fc
aoe damage does not hit main target
criller7070 Jun 24, 2026
10cd9f5
cleaner secondary targeting
criller7070 Jun 25, 2026
988560d
Merge branch 'midnight' into font-of-venomous-rage_implementation
nyterage Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
69 changes: 69 additions & 0 deletions engine/player/unique_gear_midnight.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3118,6 +3118,73 @@ void vile_vial_of_volatile_venom( special_effect_t& effect )
effect.has_use_buff_override = true;
effect.execute_action = create_proc_action<vile_vial_of_volatile_venom_t>( "empowering_venom", effect );
}

// 1297908 driver
// 1297911 equip driver
// 1307222 Venom Splatter
void font_of_venomous_rage( special_effect_t& effect )
{
struct venom_splatter_t : public generic_aoe_proc_t
{
venom_splatter_t( const special_effect_t& e ) :
generic_aoe_proc_t( e, "venom_splatter", e.player->find_spell( 1307222 ) )
{}

size_t available_targets( std::vector<player_t*>& tl ) const override

@nyterage nyterage Jun 24, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be able to use target_filter_callback for this rather than manually adjusting available_targets.

specifically target_filter_callback = secondary_targets_only();.

@criller7070 criller7070 Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neat! i just found an earlier implementation of a way to remove main target

{
generic_aoe_proc_t::available_targets( tl );
range::erase_remove( tl, target );
return tl.size();
}
};

struct font_channel_t : public proc_spell_t
{
action_t* venom_splatter;

font_channel_t( const special_effect_t& e ) :
proc_spell_t( "font_of_venemous_rage", e.player, e.driver() )
{
unsigned equip_id = 1297911;
auto equip = find_special_effect( e.player, equip_id );
assert( equip && "Font of Venomous Rage missing equip effect" );

channeled = true;

base_td = equip->driver()->effectN( 1 ).average( e );
base_td_multiplier *= role_mult( e );

venom_splatter = create_proc_action<venom_splatter_t>( "venom_splatter", e );
venom_splatter->base_dd_min = venom_splatter->base_dd_max = equip->driver()->effectN( 2 ).average( e );
venom_splatter->base_multiplier *= role_mult( e );
venom_splatter->dual = true;
add_child( venom_splatter );
}

void execute() override
{
proc_spell_t::execute();
event_t::cancel( player->readying );
player->reset_auto_attacks( composite_dot_duration( execute_state ) );
}

void tick( dot_t* d ) override
Comment thread
nyterage marked this conversation as resolved.
{
proc_spell_t::tick( d );
venom_splatter->execute_on_target( d->target );
}

void last_tick( dot_t* d ) override
{
bool was_channeling = player->channeling == this;
proc_spell_t::last_tick( d );
if ( was_channeling && !player->readying )
player->schedule_ready( rng().gauss( sim->channel_lag ) );
}
};

effect.execute_action = create_proc_action<font_channel_t>( "font_of_venemous_rage", effect );
}
} // namespace trinkets

namespace weapons
Expand Down Expand Up @@ -4158,6 +4225,8 @@ void register_special_effects()
set_min_version( wowv_t( 12, 1, 0 ) );
register_special_effect( 1293316, trinkets::vile_vial_of_volatile_venom );
register_special_effect( 1295179, DISABLED_EFFECT ); // Vile Vial of Volatile Venom equip driver
register_special_effect( 1297908, trinkets::font_of_venomous_rage );
register_special_effect( 1297911, DISABLED_EFFECT ); // Font of Venomous Rage equip driver
reset_version_check();
// Weapons
register_special_effect( { 1253357, 1253359 }, weapons::torments_duality ); // umbral sabre & radiant foil
Expand Down
Loading