Skip to content

[TEST] Add void return type declarations to test helpers#32

Merged
beatrycze-volk merged 3 commits into
slub:masterfrom
beatrycze-volk:functions
Jun 24, 2026
Merged

[TEST] Add void return type declarations to test helpers#32
beatrycze-volk merged 3 commits into
slub:masterfrom
beatrycze-volk:functions

Conversation

@beatrycze-volk

@beatrycze-volk beatrycze-volk commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

Depends on #31

Drop support for PHP 7.4, making PHP 8.2 the new minimum requirement for the project.

This update also includes bumping PHPStan and PHPUnit to their latest major versions, ensuring compatibility with modern PHP environments and leveraging new features from these development tools.
Migrate PHPUnit test method annotations from the legacy `@test` docblock tag to the native PHP 8 `#[Test]` attribute syntax. This aligns the test suite with modern PHP practices as part of the ongoing PHP version update.
Explicitly declare the 'void' return type for private static helper methods across the test suite. This enhances type safety and code clarity, aligning with modern PHP type-hinting standards.
@beatrycze-volk beatrycze-volk added this to the PHP MODS Reader 1.0.0 milestone Jun 22, 2026
@beatrycze-volk beatrycze-volk self-assigned this Jun 22, 2026
@beatrycze-volk beatrycze-volk added the test Test coverage label Jun 22, 2026
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@beatrycze-volk beatrycze-volk merged commit e766aea into slub:master Jun 24, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test Test coverage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant